Add support for parsing UUIDs between braces #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kinggoesgaming Did I miss anything with the formatting/parsing? I haven't actually worked on these modules before I think. |
|
Other than the inlining, (which we already discussed that we can do later), everything else looks good 👍🏼 |
|
Great! I've also just added a fuzzing target for the parser to make sure we never panic. Since it's likely to be used in edge scenarios any panics would probably be considered denial of service vulnerabilities. I'll let that sit and run for a while on my machine here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
This PR lets us format and parse UUIDs that are surrounded by braces:
These are common in Windows, and correspond to the
Bformat specified for C#'s GUIDs. They also have a format surrounded by parenthesis but I've never seen that one used myself in practice.Related Issue(s)
Closes #513