Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing UUIDs between braces #552

Merged
merged 2 commits into from Nov 2, 2021

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Nov 1, 2021

Description

This PR lets us format and parse UUIDs that are surrounded by braces:

{6d93bade-bd9f-4e13-8914-9474e1e3567b}

These are common in Windows, and correspond to the B format specified for C#'s GUIDs. They also have a format surrounded by parenthesis but I've never seen that one used myself in practice.

Related Issue(s)

Closes #513

@KodrAus
Copy link
Member Author

@KodrAus KodrAus commented Nov 1, 2021

@kinggoesgaming Did I miss anything with the formatting/parsing? I haven't actually worked on these modules before I think.

@kinggoesgaming
Copy link
Member

@kinggoesgaming kinggoesgaming commented Nov 1, 2021

Other than the inlining, (which we already discussed that we can do later), everything else looks good 👍🏼

@KodrAus
Copy link
Member Author

@KodrAus KodrAus commented Nov 1, 2021

Great! I've also just added a fuzzing target for the parser to make sure we never panic. Since it's likely to be used in edge scenarios any panics would probably be considered denial of service vulnerabilities. I'll let that sit and run for a while on my machine here.

@KodrAus KodrAus merged commit 1414f2d into uuid-rs:main Nov 2, 2021
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants