Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some inline comments to the new parser impl #563

merged 2 commits into from Nov 15, 2021


Copy link

@KodrAus KodrAus commented Nov 14, 2021

cc @Nugine @QnnOkabayashi

This just adds some inline comments to the parser implementation so it's easier for new contributors to follow.

Copy link

@QnnOkabayashi QnnOkabayashi left a comment

Darn I would've liked to have reviewed Nugine's PR but I didn't see it before this. Looks good though!

Nugine approved these changes Nov 15, 2021
Copy link

@Nugine Nugine left a comment


shared/ Show resolved Hide resolved
shared/ Show resolved Hide resolved
Copy link
Member Author

@KodrAus KodrAus commented Nov 15, 2021

Sorry @QnnOkabayashi! I'll remember to keep you CC'd on these 🙇

@KodrAus KodrAus merged commit f362d7d into uuid-rs:main Nov 15, 2021
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants