Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert default compact serialization #564

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Revert default compact serialization #564

merged 2 commits into from
Nov 16, 2021

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Nov 15, 2021

Closes #557

It turns out that serializing as a [u8; 16] is not really a better default than &[u8], so this PR reverts it in favor of the current stable implementation.

@KodrAus
Copy link
Member Author

KodrAus commented Nov 15, 2021

I've also just added a few more variants to our error type so the messages make more sense when looking at a byte slice and made the signature of Uuid::try_parse suitable for our public API.

@KodrAus KodrAus merged commit a1df52a into uuid-rs:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink the serde [u8; 16] binary representation
1 participant