Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the parsed literal as the span source for errors #591

Merged
merged 1 commit into from Mar 14, 2022
Merged

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Mar 14, 2022

Closes #585

It turns out the span attached to our token stream doesn't cover the actual content we want to subspan. This fixes that up by threading our parsed literal to errors to report diagnostics on.

@KodrAus KodrAus merged commit 767f519 into main Mar 14, 2022
19 checks passed
@KodrAus KodrAus deleted the fix/macro-diagnostics branch Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant