Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chmod use std where possible instead of libc; compile for Redox #1054

Merged
merged 2 commits into from Jul 24, 2017

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Jul 23, 2017

No description provided.

@Arcterus
Copy link
Member

Does this still work with the setuid, setgid, and sticky bits? I just want to make sure before I merge this because, IIRC, I had to use stuff from libc to get them to work when I first wrote chmod.

@ids1024
Copy link
Contributor Author

ids1024 commented Jul 23, 2017

It appears to work.

@Arcterus
Copy link
Member

Can you add a note in the help message that umask is not respected on Redox (if it's applicable, not too familiar with Redox atm)?

The build seems to fail on OS X because mode_t is a u16, so casting last_mask to a u32 should fix it.

@ids1024
Copy link
Contributor Author

ids1024 commented Jul 24, 2017

I've added a comment to the code about umask on Redox; it isn't currently implemented by Redox.

@Arcterus Arcterus merged commit f4f80f0 into uutils:master Jul 24, 2017
@Arcterus
Copy link
Member

Thanks :)

@ids1024 ids1024 deleted the chmod branch July 24, 2017 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants