Make chmod use std where possible instead of libc; compile for Redox #1054
Conversation
Does this still work with the setuid, setgid, and sticky bits? I just want to make sure before I merge this because, IIRC, I had to use stuff from |
It appears to work. |
Can you add a note in the help message that The build seems to fail on OS X because |
I've added a comment to the code about umask on Redox; it isn't currently implemented by Redox. |
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.