From ca542cdf24dbb480968c24d19fee0811d4b01573 Mon Sep 17 00:00:00 2001 From: oech3 <79379754+oech3@users.noreply.github.com> Date: Tue, 7 Apr 2026 20:32:45 +0900 Subject: [PATCH] cat: call pipe() once with multiple input --- src/uu/cat/src/splice.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/uu/cat/src/splice.rs b/src/uu/cat/src/splice.rs index 87cbff81a3e..4bb144ee40a 100644 --- a/src/uu/cat/src/splice.rs +++ b/src/uu/cat/src/splice.rs @@ -23,6 +23,8 @@ pub(super) fn write_fast_using_splice( handle: &InputHandle, write_fd: &S, ) -> CatResult { + use std::{fs::File, sync::OnceLock}; + static BROKER: OnceLock> = OnceLock::new(); if splice(&handle.reader, &write_fd, MAX_ROOTLESS_PIPE_SIZE).is_ok() { // fcntl improves throughput // todo: avoid fcntl overhead for small input, but don't fcntl inside of the loop @@ -34,7 +36,7 @@ pub(super) fn write_fast_using_splice( Err(_) => return Ok(true), } } - } else if let Ok((pipe_rd, pipe_wr)) = pipe() { + } else if let Some((pipe_rd, pipe_wr)) = BROKER.get_or_init(|| pipe().ok()).as_ref() { // both of in/output are not pipe. needs broker to use splice() with additional costs loop { match splice(&handle.reader, &pipe_wr, MAX_ROOTLESS_PIPE_SIZE) {