Skip to content

fix install same file with backup flag#12716

Open
zhw2101024 wants to merge 1 commit into
uutils:mainfrom
zhw2101024:fix_install_same_file_with_backup
Open

fix install same file with backup flag#12716
zhw2101024 wants to merge 1 commit into
uutils:mainfrom
zhw2101024:fix_install_same_file_with_backup

Conversation

@zhw2101024

Copy link
Copy Markdown
Contributor

Fixes #12696.
In fact, whenever we use the backup flag with the same file, it need to report that the src and dst are the same file.

@zhw2101024 zhw2101024 force-pushed the fix_install_same_file_with_backup branch from 8a47629 to 4e3891c Compare June 8, 2026 11:38
Comment thread tests/by-util/test_install.rs Outdated
@zhw2101024 zhw2101024 force-pushed the fix_install_same_file_with_backup branch 4 times, most recently from 5e11f92 to 14a8c40 Compare June 8, 2026 16:28
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/expand/bounded-memory is now passing!

@zhw2101024

Copy link
Copy Markdown
Contributor Author

@sylvestre all tests have passed, please have a look.

@zhw2101024 zhw2101024 force-pushed the fix_install_same_file_with_backup branch from 14a8c40 to f1cbc41 Compare June 9, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(install): same file for dst and src cause the file from being moved to ~<FILE>, and the original file gone when using the --backup='nil' flag

2 participants