-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feature(install) - add group & owner support + a refactor #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
71f959c
to
3b76857
Compare
3b76857
to
8ab6be9
Compare
@rivy @Arcterus @nbraud In this PR, I would like to use the actual binary name instead of uucore. Otherwise, it causes unexpected output and test failure like:
Any idea how to fix that? thanks |
Yeah, don't implement it as a straight copy of the code... avoid UI I/O within |
@sylvestre , I know I read something about why you wanted to do this... but I can't find the email/post. |
@rivy because the "install" command can change the ownership & group of a file. As we are already doing this for chgrp & chown, I think it would be better to have it uucore and make them reusable by both programs. |
I was hoping for something easier but you are right, I will do that, thanks :) |
110b0c6
to
f64018b
Compare
f64018b
to
5b96e09
Compare
…t into install Will move chown later
…wner support use it
f4d2c1d
to
995d4e1
Compare
995d4e1
to
dca1f28
Compare
For this, move the chown & chgrp functions to uucore
As we need this feature for install too