-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
runcon: added implementation and tests. #2574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You are really impressive! Only stty will be missing after this is merged! |
miDeb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work! I only found some small issues.
|
@miDeb, thank you for the review. I implemented the discussed changes. Can you take a look? |
|
The following testing tasks are still pending for this command:
|
You can do this with the |
|
Only stty left as a program, wahou! |
|
Added implementation and tests for the
runconcommand.For reference: Supporting-SELinux-in-the-coreutils.
The following testing tasks are still pending for this command:
I checked this manually by comparing the operation of the GNU implementation with our implementation through strace. I hope we can find a way to check this automatically instead.
All
runcontests succeed on a virtual machine with SELinux enabled:Closes #1973.