refactor: extract timezone functionality from time module to timezone module #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuankunzhang
changed the title
yuankunzhang
force-pushed
the
refactor-timezone-related-code
branch
2 times, most recently
from
4a71046 to
4557e92
Compare
… module. Move timezone-related code from `time.rs` to `timezone.rs` to improve separation of concerns. The `Offset` struct and all timezone parsing functions are now properly separated from time parsing logic.
cakebaker
force-pushed
the
refactor-timezone-related-code
branch
from
4557e92 to
2bc18c5
Compare
Collaborator
|
Good work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.