Permalink
Commits on Jun 4, 2014
  1. feature #10552 [YAML] Added support for object-maps (polyfractal, nic…

    fabpot committed Jun 4, 2014
    …olas-grekas)
    
    This PR was merged into the 2.5-dev branch.
    
    Discussion
    ----------
    
     [YAML] Added support for object-maps
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | NA
    | License       | MIT
    | Doc PR        | NA
    
    Proposal for symfony#10114
    
    Commits
    -------
    
    0cee604 [Yaml] Cleanups for object maps
    e2d5468 [Yaml] Added support for object maps
  2. [Yaml] Added support for object maps

    polyfractal authored and nicolas-grekas committed Jan 23, 2014
    Previously, the parser treated maps ( {} ) the same as sets ( [] ).
    Both were returned as PHP associative arrays. Since
    these are distinct entities, this can cause considerably problems for
    the users, especially when YAML is being serialized into another
    format such as JSON.
    
    This commit allows the user to enable object-map support via a third
    parameter on the Parse method.  It defaults to `false`, which means
    that this commit does not break backwards compatibility.
    
    If the user enables object-map support, maps are represented
    by stdClass() objects.  Sets remain as arrays.
Commits on Jun 3, 2014
  1. feature #9990 [SecurityBundle] added acl:set command (dunglas)

    fabpot committed Jun 3, 2014
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    [SecurityBundle] added acl:set command
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | no
    | License       | MIT
    | Doc PR        | n/a
    
    This new command allows to set ACL directly from the command line. This useful to quickly set up an environment and for debugging / maintenance purpose.
    
    This PR also includes a functional test system for the ACL component. As an example, it is used to test the `acl:set` command.
    The provided entity class is not mandatory (tests will still be green without it) but can be useful to test other ACL related things. I can remove it if necessary.
    
    The instantiation of the `MaskBuilder` object is done in a separate method to be easily overridable to use a custom one (e.g. the SonataAdmin one).
    
    Commits
    -------
    
    a702124 [SecurityBundle] added acl:set command
  2. feature #10667 [HttpFoundation] Add a way to match a specific scheme …

    fabpot committed Jun 3, 2014
    …in RequestMatcher #10556 (ProPheT777)
    
    This PR was squashed before being merged into the 2.6-dev branch (closes #10667).
    
    Discussion
    ----------
    
    [HttpFoundation] Add a way to match a specific scheme in RequestMatcher #10556
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #10556
    | License       | MIT
    | Doc PR        |  no
    
    Commits
    -------
    
    787ae07 [HttpFoundation] Add a way to match a specific scheme in RequestMatcher #10556
  3. feature #10699 [DomCrawler] Added support for slicing nodes (Berat Do…

    fabpot committed Jun 3, 2014
    …ğan, beratdogan)
    
    This PR was squashed before being merged into the 2.6-dev branch (closes #10699).
    
    Discussion
    ----------
    
    [DomCrawler] Added support for slicing nodes
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    
    There are no easy way to slice nodes in specific range. I created a method using \LimitIterator. Works fine for me.
    
    An example using is:
    ```php
         $crawler->filter('h1')->slice(5, 10)->each(function ($node, $i) {
             return $node->text();
         });
    
    Commits
    -------
    
    1181bdc [DomCrawler] Added support for slicing nodes
  4. [DomCrawler] Added support for slicing nodes

    Berat Doğan authored and fabpot committed Apr 13, 2014
  5. feature #10792 [Security] Allow overloading ContextListener::refreshU…

    fabpot committed Jun 3, 2014
    …ser() (lstrojny)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    [Security] Allow overloading ContextListener::refreshUser()
    
    Allow overloading refreshUser() for the use case of doing something special with user providers.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n.A.
    | License       | MIT
    | Doc PR        | n.A.
    
    Commits
    -------
    
    b67ed43 Allow overloading ContextListener::refreshUser()
  6. minor #10980 error.html.twig should contain a email value (clemens-to…

    fabpot committed Jun 3, 2014
    …lboom)
    
    This PR was squashed before being merged into the 2.3-dev branch (closes #10980).
    
    Discussion
    ----------
    
    error.html.twig should contain a email value
    
    When getting an exception on env PROD it would be nice to have an email to report to.
    
    Current code has [email] instead of a value.
    
    I'm not sure how to fix this as the email value should come from exception.html.twig
    
    ```html
    <div id="logs">
        {% include 'TwigBundle:Exception:logs.html.twig' with { 'logs': logger.logs } only %}
    </div>
    ```
    
    Some hints are welcome.
    
    Commits
    -------
    
    030b8c0 error.html.twig should contain a email value
  7. feature #11034 [Debug] enhanced error messages for uncaught exception…

    fabpot committed Jun 3, 2014
    …s (nicolas-grekas)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    [Debug] enhanced error messages for uncaught exceptions
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | none
    | License       | MIT
    | Doc PR        | none
    
    Before:
    
    ![capture du 2014-06-02 10 56 42](https://cloud.githubusercontent.com/assets/243674/3145281/3f8c4d24-ea34-11e3-948c-78898fb79a75.png)
    
    After:
    
    ![capture du 2014-06-02 10 55 57](https://cloud.githubusercontent.com/assets/243674/3145283/44167a86-ea34-11e3-9786-f77f2f001638.png)
    
    A double-click on the file name switches between short/full path name.
    
    Commits
    -------
    
    ce66442 [Debug] enhanced error messages for uncaught exceptions
Commits on May 31, 2014
  1. Merge branch '2.5'

    fabpot committed May 31, 2014
    * 2.5:
      [Validator] Remove property and method targets from the optional and required constraints.
      fixed CHANGELOG for 2.5
      bumped Symfony version to 2.5.0
      updated VERSION for 2.5.0-RC1
      updated CHANGELOG for 2.5.0-RC1
      [DomCrawler] Fixed charset detection in html5 meta charset tag
  2. Merge branch '2.4' into 2.5

    fabpot committed May 31, 2014
    * 2.4:
      [Validator] Remove property and method targets from the optional and required constraints.
      [DomCrawler] Fixed charset detection in html5 meta charset tag
  3. Merge branch '2.3' into 2.4

    fabpot committed May 31, 2014
    * 2.3:
      [Validator] Remove property and method targets from the optional and required constraints.
      [DomCrawler] Fixed charset detection in html5 meta charset tag
  4. bug #11014 [Validator] Remove property and method targets from the op…

    fabpot committed May 31, 2014
    …tional and required constraints (jakzal)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Validator] Remove property and method targets from the optional and required constraints
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |  #11013
    | License       | MIT
    | Doc PR        |
    
    At the moment both constraints can only be defined on other annotations. Both constraints are [only mentioned in the docs in the context of the Collection](http://symfony.com/doc/current/reference/constraints/Collection.html#required-and-optional-field-constraints).
    
    Defining the required or optional annotation directly on a field or method
    throws a ClassNotFoundException, since the constraint validator factory tries to load the validator (which does not exist):
    
    ```
    ClassNotFoundException: Attempted to load class "OptionalValidator"
    from namespace "Symfony\Component\Validator\Constraints"
    in /var/www/server/vendor/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Validator/ConstraintValidatorFactory.php line 71.
    Do you need to "use" it from another namespace?
    ```
    
    By applying this patch the end user will get a more helpful error message:
    
    ```
    [Semantical Error] Annotation @Assert\Optional is not allowed to be declared on property Acme\DemoBundle\Entity\Contact::$message.
    You may only use this annotation on these code elements: ANNOTATION.
    ```
    
    Commits
    -------
    
    9c2616e [Validator] Remove property and method targets from the optional and required constraints.
Commits on May 29, 2014
  1. [Validator] Remove property and method targets from the optional and …

    jakzal committed May 29, 2014
    …required constraints.
    
    At the moment both constraints can only be defined on other annotations (specifically, the Collection annotation). Defining the required or optional annotation directly on a field or method throws a ClassNotFoundException, since the constraint validator factory tries to load the validator (which does not exist).
Commits on May 28, 2014
  1. fixed CHANGELOG for 2.5

    fabpot committed May 28, 2014
  2. updated VERSION for 2.5.0-RC1

    fabpot committed May 28, 2014
Commits on May 26, 2014
  1. bug #10983 [DomCrawler] Fixed charset detection in html5 meta charset…

    fabpot committed May 26, 2014
    … tag (77web)
    
    This PR was squashed before being merged into the 2.3 branch (closes #10983).
    
    Discussion
    ----------
    
    [DomCrawler] Fixed charset detection in html5 meta charset tag
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    
    It may be minor to folks with ascii-charactered language, but is critical for us Japanese.
    Many Japanese websites with SJIS encoding have "Shift_JIS" as their encoding declaration.
    
    Commits
    -------
    
    172e752 [DomCrawler] Fixed charset detection in html5 meta charset tag
  2. Merge branch '2.5'

    fabpot committed May 26, 2014
    * 2.5:
      Revert "bug #10908 [HttpFoundation] implement session locking for PDO (Tobion)"
  3. Revert "bug #10908 [HttpFoundation] implement session locking for PDO…

    fabpot committed May 26, 2014
    … (Tobion)"
    
    This reverts commit 8c71454, reversing
    changes made to 735e9a4.
  4. Merge branch '2.5'

    fabpot committed May 26, 2014
    * 2.5:
      Revert "bug #10894 [HttpKernel] removed absolute paths from the generated container (fabpot)"
      Revert "bug #10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)"
      Revert "fixed CS"
      Revert "bug #10979 Make rootPath part of regex greedy (artursvonda)"
      Revert "[HttpKernel] simplified some tests"
      [HttpKernel] simplified some tests
      Make rootPath part of regex greedy
  5. Merge branch '2.4' into 2.5

    fabpot committed May 26, 2014
    * 2.4:
      Revert "bug #10894 [HttpKernel] removed absolute paths from the generated container (fabpot)"
      Revert "bug #10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)"
      Revert "fixed CS"
      Revert "bug #10979 Make rootPath part of regex greedy (artursvonda)"
      Revert "[HttpKernel] simplified some tests"
      [HttpKernel] simplified some tests
      Make rootPath part of regex greedy
  6. Merge branch '2.3' into 2.4

    fabpot committed May 26, 2014
    * 2.3:
      Revert "bug #10894 [HttpKernel] removed absolute paths from the generated container (fabpot)"
      Revert "bug #10937 [HttpKernel] Fix "absolute path" when we look to the cache directory (BenoitLeveque)"
      Revert "fixed CS"
      Revert "bug #10979 Make rootPath part of regex greedy (artursvonda)"
      Revert "[HttpKernel] simplified some tests"
      [HttpKernel] simplified some tests
      Make rootPath part of regex greedy
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Tests/KernelTest.php
  7. Revert "bug #10894 [HttpKernel] removed absolute paths from the gener…

    fabpot committed May 26, 2014
    …ated container (fabpot)"
    
    This reverts commit 735e9a4, reversing
    changes made to 5c91dc1.
  8. Revert "bug #10937 [HttpKernel] Fix "absolute path" when we look to t…

    fabpot committed May 26, 2014
    …he cache directory (BenoitLeveque)"
    
    This reverts commit 7dc8931, reversing
    changes made to 309046a.
  9. Revert "fixed CS"

    fabpot committed May 26, 2014
    This reverts commit 11816c5.
  10. Revert "bug #10979 Make rootPath part of regex greedy (artursvonda)"

    fabpot committed May 26, 2014
    This reverts commit 9766c72, reversing
    changes made to 168174a.
  11. Revert "[HttpKernel] simplified some tests"

    fabpot committed May 26, 2014
    This reverts commit ccacd8d.