New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-line option --threads does not work? #145

Closed
LebedevRI opened this Issue Jun 9, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@LebedevRI
Contributor

LebedevRI commented Jun 9, 2016

If i pass --threads, it does not work, if i do not pass it, it works.

~/src/herbie$ racket ~/src/herbie/src/reports/run.rkt --fuel 4 --threads 8 soe.rkt
place-channel-put: value not allowed in a message
  value: '#hash((generate . (rr taylor simplify)) (precision . (double)) (reduce . (regimes taylor simplify avg-error)) (rules . (arithmetic polynomials fractions exponents trigonometry)) (setup . (simplify)))
  message: '(init rand #(4288444397 53123915 1983666923 3817731407 1010350898 2389601263) flags #hash((generate . (rr taylor simplify)) (precision . (double)) (reduce . (regimes taylor simplify avg-error)) (rules . (arithmetic polynomials fractions exponents trigo...
  context...:
   /home/lebedevri/src/herbie/src/reports/thread-pool.rkt:94:0: run-workers25
   /home/lebedevri/src/herbie/src/reports/thread-pool.rkt:159:0: get-test-results43
   /home/lebedevri/src/herbie/src/reports/run.rkt:25:0: make-report
   /home/lebedevri/src/herbie/src/reports/run.rkt: [running body]
~/src/herbie$ racket ~/src/herbie/src/reports/run.rkt --fuel 4 --threads 1 soe.rkt
place-channel-put: value not allowed in a message
  value: '#hash((generate . (rr taylor simplify)) (precision . (double)) (reduce . (regimes taylor simplify avg-error)) (rules . (arithmetic polynomials fractions exponents trigonometry)) (setup . (simplify)))
  message: '(init rand #(308998630 4110963146 1817948267 4251213394 1222084849 803791841) flags #hash((generate . (rr taylor simplify)) (precision . (double)) (reduce . (regimes taylor simplify avg-error)) (rules . (arithmetic polynomials fractions exponents trigo...
  context...:
   /home/lebedevri/src/herbie/src/reports/thread-pool.rkt:94:0: run-workers25
   /home/lebedevri/src/herbie/src/reports/thread-pool.rkt:159:0: get-test-results43
   /home/lebedevri/src/herbie/src/reports/run.rkt:25:0: make-report
   /home/lebedevri/src/herbie/src/reports/run.rkt: [running body]
~/src/herbie$ racket ~/src/herbie/src/reports/run.rkt --fuel 4 --threads yes soe.rkt
place-channel-put: value not allowed in a message
  value: '#hash((generate . (rr taylor simplify)) (precision . (double)) (reduce . (regimes taylor simplify avg-error)) (rules . (arithmetic polynomials fractions exponents trigonometry)) (setup . (simplify)))
  message: '(init rand #(621398415 1604270261 3634038359 1009051999 3837243482 1690531221) flags #hash((generate . (rr taylor simplify)) (precision . (double)) (reduce . (regimes taylor simplify avg-error)) (rules . (arithmetic polynomials fractions exponents trig...
  context...:
   /home/lebedevri/src/herbie/src/reports/thread-pool.rkt:94:0: run-workers25
   /home/lebedevri/src/herbie/src/reports/thread-pool.rkt:159:0: get-test-results43
   /home/lebedevri/src/herbie/src/reports/run.rkt:25:0: make-report
   /home/lebedevri/src/herbie/src/reports/run.rkt: [running body]
~/src/herbie$ racket ~/src/herbie/src/reports/run.rkt --fuel 4 soe.rkt
Starting Herbie on 1 problems...
Seed: #(1001121629 1217222885 1342864862 3040828424 1285742257 2113176950)
  1/1   [ 40617.98ms]   ( 0→ 0) specific orbital energy
~/src/herbie$ 
@pavpanchekha

This comment has been minimized.

Show comment
Hide comment
@pavpanchekha

pavpanchekha Jun 10, 2016

Contributor

I'm not entirely sure what the problem is; in any case, the --threads flag only sends different inputs to different threads, so if you have a single input you don't want threads anyway. For our 1.0 release we won't be releasing the threads code (or the reports infrastructure that you are using), so it might still have some bugs.

I'll look into this nonetheless. You're still on 6.5, right?

Contributor

pavpanchekha commented Jun 10, 2016

I'm not entirely sure what the problem is; in any case, the --threads flag only sends different inputs to different threads, so if you have a single input you don't want threads anyway. For our 1.0 release we won't be releasing the threads code (or the reports infrastructure that you are using), so it might still have some bugs.

I'll look into this nonetheless. You're still on 6.5, right?

@LebedevRI

This comment has been minimized.

Show comment
Hide comment
@LebedevRI

LebedevRI Jun 10, 2016

Contributor

Yes, still 6.5

Contributor

LebedevRI commented Jun 10, 2016

Yes, still 6.5

@pavpanchekha

This comment has been minimized.

Show comment
Hide comment
@pavpanchekha

pavpanchekha May 3, 2017

Contributor

Lebedev, we've made quite a few changes to Herbie since this bug was filed, including a rework of the threading infrastructure. While I've never been able to reproduce your bug, I do hope that it's gone away in the rewrite. Please let me know if it hasn't; otherwise, I am closing this bug.

Contributor

pavpanchekha commented May 3, 2017

Lebedev, we've made quite a few changes to Herbie since this bug was filed, including a rework of the threading infrastructure. While I've never been able to reproduce your bug, I do hope that it's gone away in the rewrite. Please let me know if it hasn't; otherwise, I am closing this bug.

@LebedevRI

This comment has been minimized.

Show comment
Hide comment
@LebedevRI

LebedevRI May 3, 2017

Contributor

Thanks, if i encounter it again, i will report.

Contributor

LebedevRI commented May 3, 2017

Thanks, if i encounter it again, i will report.

@pavpanchekha

This comment has been minimized.

Show comment
Hide comment
@pavpanchekha

pavpanchekha May 3, 2017

Contributor

Great! Let us know what you think of the new release when you check it out :)

Contributor

pavpanchekha commented May 3, 2017

Great! Let us know what you think of the new release when you check it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment