Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master

Jul 17, 2012

  1. Fix an IDBDatabase exception in objectstore.

    Chrome 21 throws an IDBDatabase exception 21 (TYPE_ERR) when passing an undefined direction to store.openCursor.
    
    R=nweiz
    DELTA=6  (3 added, 0 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5165
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2045 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    ofir@google.com authored
  2. Fixing key lookup for RTL languages in goog.ui.SubMenu.

    R=chrishenry
    DELTA=26  (15 added, 1 deleted, 10 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5164
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2044 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    miloss@google.com authored
  3. Make sure the alt key flag is saved during key down and reused at key…

    … press for FF on Mac.
    
    Alt key flag was not set for above mentioned setup on key press.
    
    R=arv
    DELTA=71  (71 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5163
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2043 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    vencel@google.com authored
  4. Remove deprecated functions goog.ui.Popup.positionPopup and goog.ui.P…

    …opup.positionAtCoordinate.
    
    R=chrishenry
    DELTA=65  (0 added, 65 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5162
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2042 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jonathanasdf@google.com authored
  5. Fix Editor stops responding on Tablet

    The cause of this issue:
    iOS bug that occurs in following condition
    - parent window embeds child window that has the element with contenteditable like as goog.editor.Field
    - parent window listens touch events
    
    How to fix:
    refocus the editor window on keydown(for text input) and touchend(for copy/paste).
    
    R=nicksantos
    DELTA=39  (38 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5161
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2041 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    kiyono@google.com authored
  6. Fix the issue where calling popup.setVisible twice with the same para…

    …meter in the same frame and a transition set will cause a leaked timer.
    
    R=chrishenry
    DELTA=108  (78 added, 27 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5160
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2040 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jonathanasdf@google.com authored

Jul 16, 2012

  1. Make AbstractDragDrop.isInside protected rather than private.

    R=eae
    DELTA=30  (0 added, 0 deleted, 30 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5159
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2039 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    lyczak@google.com authored

Jul 14, 2012

  1. Showing character names in the character picker widget. These names a…

    …re provided by a webservice which is accessed asynchronously by the closure code.
    
    R=chrishenry,cibu
    DELTA=819  (736 added, 22 deleted, 61 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5158
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2038 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    rwainman@google.com authored

Jul 13, 2012

  1. Automated g4 rollback

    *** Reason for rollback ***
    
    After the CL, goog.Disposable is not a no-op, and cannot be compiled
    out. This is unacceptable.
    
    *** Original change description ***
    
    Disposable monitoring mode: Enable starting the monitoring mode on the fly.
    
    Some Disposables might be created before the monitoring mode was started,
    don't throw an error when they are disposed.
    
    To catch the "base class constructor not called" error in the monitoring mode,
    make disposed_ undefined unless the base class constructor was called, and
    check
    
    ... description truncated by g4 rollback ...
    
    R=ssaviano
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5154
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2037 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    marja@google.com authored

Jul 12, 2012

  1. In Deferred, rethrow the original error instead of

    wrapping in a goog.async.Deferred.UnhandledError.
    
    Remove all active references to UnhandledError.
    
    R=felixarends,nicksantos,zachlloyd,mknichel
    DELTA=88  (5 added, 57 deleted, 26 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5153
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2036 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    brenneman@google.com authored
  2. Add goog.editor.ContentEditableField, which is a lighter replacement

    for SeamlessField for clients that only support modern browsers with
    good ContentEditable support.
    
    Firefox 12+ finally has good contentEditable support and already
    comprises the vast majority of Firefox users.
    
    Note this does not change HAS_CONTENT_EDITABLE yet, since that may
    break many other things; further testing is needed.
    
    This also moves goog.editor.Field's tests to a separate JS file.
    Although I normally don't like this pattern, given how complicated text
    editing is and how many points are dependent on whether there's an
    iframe, I think it's fine to run all of Field's tests for both Field
    and ContentEditableField.
    
    R=nicksantos
    DELTA=2460  (1366 added, 1088 deleted, 6 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5147
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2035 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    gboyer@google.com authored
  3. Fix a typo in a comment.

    R=nicksantos
    DELTA=1  (0 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5146
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2034 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    carlanton@google.com authored
  4. In Gecko, when the range isn't reversed, use the normal path for

    selection (e.g. removeAllRanges() and addRange()).
    
    The ContentEditableField tests fail without fixing this. I'm mystified
    why this doesn't work -- well, mystified as much as you can possibly be
    when it comes to ranges.  In this particular case, though, I think this
    is a net improvement; in the simple cases, both forward and collapsed,
    we can use the standard W3C functionality, and only rely on Gecko
    specific code when it's reversed.
    
    R=nicksantos
    DELTA=40  (32 added, 0 deleted, 8 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5145
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2033 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    gboyer@google.com authored

Jul 11, 2012

  1. When moving popups off screen, avoids setting a negative left propert…

    …y as this can cause scrollbars to appear in RTL locales.
    
    Also increases the negative top coordinate to avoid cases where the popup is taller than 200px.
    
    R=chrishenry
    DELTA=28  (25 added, 1 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5144
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2032 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    geoffh@google.com authored
  2. Use the DomHelper's window.

    R=vbhasin
    DELTA=4  (0 added, 0 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5143
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2031 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    oprater@google.com authored
  3. Added method to reset menubutton's originalSize_ for cases where item…

    …s are remove/added when scrollOnOverflow is on.
    
    R=nicksantos
    DELTA=61  (61 added, 0 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5142
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2030 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    mschidlowsky@google.com authored

Jul 09, 2012

  1. Fixed an issue with abort(true) where it tries to remove XhrIo listen…

    …ers even if
    
    one doesn't exist for the request.
    
    Also added a getOutstandingRequests method.
    
    R=ssaviano,chrishenry
    DELTA=21  (12 added, 0 deleted, 9 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5128
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2029 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    davbennett@google.com authored
  2. Disposable monitoring mode: Enable starting the monitoring mode on th…

    …e fly.
    
    Some Disposables might be created before the monitoring mode was started,
    don't throw an error when they are disposed.
    
    To catch the "base class constructor not called" error in the monitoring mode,
    make disposed_ undefined unless the base class constructor was called, and
    check that in dispose().
    
    R=pallosp
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5127
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2028 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    marja@google.com authored

Jul 03, 2012

  1. Introduce type template to improve type inferrencing for the

    goog.array.X methods.
    
    R=chrishenry
    DELTA=315  (239 added, 0 deleted, 76 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5107
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2027 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    johnlenz@google.com authored
  2. Remove expensive 4-year-old Safari hack.

    It was apparently fixed in WebKit 525.18, in the Safari 3.1 line.
    
    R=nicksantos
    DELTA=20  (0 added, 20 deleted, 0 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5106
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2026 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    gboyer@google.com authored
  3. Fix spelling errors for reuqest. Mostly makes searching comments bett…

    …er, but there are some bonafide bugs here!
    
    R=pallosp
    DELTA=1  (0 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5105
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2025 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    plindner@google.com authored
  4. Deprecate goog.events.Event.dispose(Internal).

    R=pallosp
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5104
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2024 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    marja@google.com authored

Jul 02, 2012

  1. Change goog.fs.sliceBlob() to call slice() using the new spec.

    IE10 implements slice() according to the new spec.
    FF and Chrome also have bugs to remove their respective vendor
    prefixes:
    https://bugzilla.mozilla.org/show_bug.cgi?id=725289
    https://bugs.webkit.org/show_bug.cgi?id=78111
    
    R=nweiz,azzie
    DELTA=121  (104 added, 5 deleted, 12 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5103
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2023 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    andyehou@google.com authored
  2. Fixes GSS compiler warnings for duplicate style rules by using /* @al…

    …ternate */
    
    R=eae
    DELTA=3  (0 added, 0 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5102
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2022 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    yesudeep@google.com authored

Jun 28, 2012

  1. Set preserveParameterTypesCompatibilityFlag to false.

    Background info: goog.Uri used to preserve the type passed into
    goog.Uri#setParameterValue. That meant goog.Uri behaved differently
    in fake URIs (which are often created in tests) vs. real URIs
    (which are obviously strings).
    
    If this CL causes problems for you, you should set
    goog.Uri.preserveParameterTypesCompatibilityFlag = true;
    in your test
    
    R=gboyer
    DELTA=8  (3 added, 1 deleted, 4 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5094
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2021 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    nicksantos@google.com authored

Jun 27, 2012

  1. Add a helpful typecast

    R=chrishenry
    DELTA=2  (0 added, 0 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5090
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2020 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    nicksantos@google.com authored
  2. Made public two methods in goog.ui.SliderBase: getValueFromMousePosit…

    …ion_ and getThumbCoordinateForValue_
    
    Methods renamed omitting the trailing underscore.
    
    R=arv
    DELTA=80  (66 added, 2 deleted, 12 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5089
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2019 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    allons@google.com authored
  3. Fix broken closure tests (added missing goog.require's)

    R=nnaze
    DELTA=11  (7 added, 2 deleted, 2 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5088
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2018 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    vbhasin@google.com authored

Jun 26, 2012

  1. Add "data-" attributes to the list of properties that should be set u…

    …sing .setAttribute() in createDom().
    
    R=chrishenry
    DELTA=16  (15 added, 0 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5087
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2017 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    mleibman@google.com authored
  2. Expose the INPUT element of the goog.ui.ComboBox and fix setDefaultTe…

    …xt() not working after the component has been rendered.
    
    R=chrishenry
    DELTA=20  (18 added, 1 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5086
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2016 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    mleibman@google.com authored
  3. Make goog.events.Event not inherit goog.Disposable.

    Many objects, especially Events, inherit goog.Disposable but are never
    dispose()d. It is considered ok since they aren't responsible of disposing
    other objects. Monitoring such objects adds unnecessary overhead.
    
    R=pallosp
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5085
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2015 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    marja@google.com authored
  4. Rename protected functions from 'result' to 'protectedFunction' so th…

    …at they
    
    make sense in stack traces.
    
    R=johnlenz,gboyer
    DELTA=3  (0 added, 0 deleted, 3 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5084
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2014 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    mwr@google.com authored

Jun 25, 2012

  1. Update goog.db and goog.fs for Chrome 18.

    This version is robust against the lack of DOMException.
    
    R=nnaze
    DELTA=64  (7 added, 32 deleted, 25 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5083
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2013 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    nweiz@google.com authored
  2. Add a highlighted header to show the test outcome.

    R=nnaze,pallosp
    DELTA=23  (12 added, 10 deleted, 1 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5082
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2012 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    jmittleman@google.com authored
  3. Modify the BidiInput's setDirection method to base its estimate of th…

    …e input's direction on estimateDirection directly. Add a unit test to BidiInput to test that directionality is correctly estimated even whether the input begins with neutral characters or with directional ones.
    
    R=nicksantos,aharon
    DELTA=94  (82 added, 1 deleted, 11 changed)
    
    
    Revision created by MOE tool push_codebase.
    MOE_MIGRATION=5081
    
    
    git-svn-id: http://closure-library.googlecode.com/svn/trunk@2011 0b95b8e8-c90f-11de-9d4f-f947ee5921c8
    davinci@google.com authored
Something went wrong with that request. Please try again.