Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Change drag/multi:drag ui events to bubblable #185

Merged
merged 1 commit into from

3 participants

@iamdustan

See #184

Tested in:

  • Chrome 25 beta
  • Opera 12.02
  • Firefox 19 beta
  • Safari 5.1
@davidaurelio

Sorry nobody took care of this yet.

@basecode: is more discussion needed? I’m ok with this change.

@basecode
Owner

Looks fine! Thanks, @iamdustan.

@iamdustan

:thumbsup: thanks @davidaurelio. I didn’t push the issue to hard since your tree traversal change hasn’t been reviewed at all either. I’m sure you guys are plenty busy with Pixelplant.

@davidaurelio

That’s true. I’d like to give some more love to bonsai

@davidaurelio davidaurelio merged commit 1d8a054 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 22, 2013
  1. @iamdustan
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +3 −1 example/library/movies/event-drag.js
  2. +2 −0  src/runner/ui_event.js
View
4 example/library/movies/event-drag.js
@@ -11,11 +11,12 @@ for (var a = 0; a < 3; ++a) {
var x, y,
fill = color('red').darker(.1).randomize('hue');
- new Rect(
+ var r = new Rect(
a * 150 + 50, b * 150 + 50, 100, 100
).attr({
fillColor: fill
})
+ var g = new Group()
.on('mouseover', function() {
this.attr('fillColor', fill.lighter(.2));
})
@@ -35,6 +36,7 @@ for (var a = 0; a < 3; ++a) {
})
.emit('multi:pointerdown')
.addTo(stage);
+ r.addTo(g);
}());
}
View
2  src/runner/ui_event.js
@@ -10,6 +10,8 @@ define(function() {
pointermove: true,
click: true,
doubleclick: true,
+ drag: true,
+ 'multi:drag': true,
'multi:pointerdown': true,
'multi:pointermove': true,
'multi:pointerup': true
Something went wrong with that request. Please try again.