Text#attr[textOrigin] #188

Merged
merged 7 commits into from Jan 24, 2013

2 participants

@basecode
uxebu member

This pull request fixes #166 and "silently" adds support for three different textOrigins. Namely "top", "center" and "bottom".

@davidaurelio davidaurelio was assigned Jan 24, 2013
@basecode
uxebu member

The reason why I propose "textOrigin" being a "silent" or non-public addition is because we're probably changing the behaviour of Text in the future due to #84. IMO making "textOrigin" public would conflict with the idea of exposing a "verticalAlign" API. Could be that the Text API ends up being kind of a TextBox API.

@davidaurelio davidaurelio merged commit 3229320 into master Jan 24, 2013
@davidaurelio
uxebu member

Thanks

@davidaurelio davidaurelio deleted the text-origin branch Jan 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment