New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dropdown border variables #1237
Conversation
@@ -21,6 +21,8 @@ | |||
@component-active-bg: @brand-primary; | |||
@dropdown-link-active-bg: @component-active-bg; | |||
@dropdown-link-hover-bg: @dropdown-link-active-bg; | |||
@dropdown-fallback-border: @dropdown-fallback-border; | |||
@dropdown-bg: @dropdown-bg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need these lines? O_o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, these are not necessary i removed them and now i am using the correct variable for the arrow border (@dropdown-border
) 388f192
👍 for merge. |
@vicocamacho can you add the variable also to the tbws2 less file? and add the parameter to the build.less & build3.less file with the color code currently in the datepicker(3).less file |
Sure, will do it in the next few days |
I don't know if you guys saw this, is this what was needed? thank you! |
Just add the variables to the |
is this correct? vicocamacho@6faf3b4 |
will look into it in the next few weeks |
Add support for dropdown border variables
LGTM, thanks, merged. |
Maybe we should add a styling section to the docs, where we can describe this feature |
Add the Bootstrap variables for the arrow of the datepicker: