Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dropdown border variables #1237

Merged
merged 4 commits into from Sep 13, 2015

Conversation

vicocamacho
Copy link
Contributor

Add the Bootstrap variables for the arrow of the datepicker:

screen shot 2015-01-14 at 9 30 30 pm

@@ -21,6 +21,8 @@
@component-active-bg: @brand-primary;
@dropdown-link-active-bg: @component-active-bg;
@dropdown-link-hover-bg: @dropdown-link-active-bg;
@dropdown-fallback-border: @dropdown-fallback-border;
@dropdown-bg: @dropdown-bg;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need these lines? O_o

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, these are not necessary i removed them and now i am using the correct variable for the arrow border (@dropdown-border) 388f192

@vsn4ik
Copy link
Member

vsn4ik commented Feb 15, 2015

👍 for merge.

@acrobat
Copy link
Member

acrobat commented Apr 5, 2015

@vicocamacho can you add the variable also to the tbws2 less file? and add the parameter to the build.less & build3.less file with the color code currently in the datepicker(3).less file

@vicocamacho
Copy link
Contributor Author

Sure, will do it in the next few days

@vicocamacho
Copy link
Contributor Author

I don't know if you guys saw this, is this what was needed? thank you!

@acrobat
Copy link
Member

acrobat commented Jun 11, 2015

Just add the variables to the build.less and build_standalone.less. Then this PR should be ready (will review it fully then!)

@vicocamacho
Copy link
Contributor Author

is this correct? vicocamacho@6faf3b4

@hebbet hebbet self-assigned this Aug 6, 2015
@hebbet
Copy link
Contributor

hebbet commented Aug 6, 2015

will look into it in the next few weeks

hebbet added a commit that referenced this pull request Sep 13, 2015
Add support for dropdown border variables
@hebbet hebbet merged commit 4f88d10 into uxsolutions:master Sep 13, 2015
@hebbet
Copy link
Contributor

hebbet commented Sep 13, 2015

LGTM, thanks, merged.

@acrobat acrobat mentioned this pull request Sep 13, 2015
2 tasks
@acrobat
Copy link
Member

acrobat commented Sep 13, 2015

Maybe we should add a styling section to the docs, where we can describe this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants