Fixing the ui displaying 'undefined nan' when typing dates in Firefox & IE #734

Merged
merged 2 commits into from Dec 13, 2014

Conversation

Projects
None yet
6 participants
@adelegard

Addresses issue eternicode#691

The issue: In firefox (tested in build 25.0.1) and IE 8/9/10, clicking into the datepicker then typing "12/24/2" results in the datepicker displaying "undefined nan":

screen shot 2013-12-09 at 8 01 00 pm

Chrome (31.0.1650.63) and Safari (6.1 (8537.71)) do not have this problem.

Clicking on the "undefined nan" text or either of the left/right arrows results in the browser crashing.

If you do not click anything in the picker when it is is this state, and instead click off the picker (to close it), it results in the input field filling in with "NaN/NaN/NaN"

screen shot 2013-12-09 at 8 01 20 pm

@acrobat

This comment has been minimized.

Show comment Hide comment
@acrobat

acrobat Jan 7, 2014

Owner

ping @eternicode any idea if and when this get merged? We have a similar isues on the latest release of the datepicker

Owner

acrobat commented Jan 7, 2014

ping @eternicode any idea if and when this get merged? We have a similar isues on the latest release of the datepicker

@monzou

This comment has been minimized.

Show comment Hide comment
@monzou

monzou Jan 30, 2014

👍

I got a same issue. Could you please merge this at 1.3.1 ?

monzou commented Jan 30, 2014

👍

I got a same issue. Could you please merge this at 1.3.1 ?

@adelegard

This comment has been minimized.

Show comment Hide comment
@adelegard

adelegard Feb 4, 2014

Just confirmed this is still an issue. Just pulled in latest master branch to my fork. Please merge this change.

Just confirmed this is still an issue. Just pulled in latest master branch to my fork. Please merge this change.

@ponchai

This comment has been minimized.

Show comment Hide comment
@ponchai

ponchai Jun 10, 2014

Is there a fix for the NaN/NaN/Nan ?

ponchai commented Jun 10, 2014

Is there a fix for the NaN/NaN/Nan ?

@herrfisk

This comment has been minimized.

Show comment Hide comment
@herrfisk

herrfisk Jun 23, 2014

I have the same bug even when not typing but using the picker

I have the same bug even when not typing but using the picker

@iamthestreets

This comment has been minimized.

Show comment Hide comment
@iamthestreets

iamthestreets Nov 17, 2014

I don't see how this issue was fixed?

I don't see how this issue was fixed?

@acrobat acrobat modified the milestones: 1.3.2, 1.3.1 Dec 10, 2014

@acrobat

This comment has been minimized.

Show comment Hide comment
@acrobat

acrobat Dec 13, 2014

Owner

Thanks @adelegard!

Owner

acrobat commented Dec 13, 2014

Thanks @adelegard!

acrobat added a commit that referenced this pull request Dec 13, 2014

Merge pull request #734 from adelegard/nan_firefox_fix
Fixing the ui displaying 'undefined nan' when typing dates in Firefox & IE

@acrobat acrobat merged commit 86f9152 into uxsolutions:master Dec 13, 2014

1 check passed

default The Travis CI build passed
Details

This was referenced Dec 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment