Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix almalinux releasefile parsing #3738

Merged

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented May 10, 2021

What does this PR change?

Bootstrapping of RedHat like products fail with a NPE in the product detection code.
Reason seems to be a missmatch in the naming of the state ID.

In java
https://github.com/uyuni-project/uyuni/blob/master/java/code/src/com/suse/manager/webui/utils/salt/custom/PkgProfileUpdateSlsResult.java#L45-L46

the ID is named almarelease but in the SLS file it was called almalinux.
Changed now to almarelease as all the other files as well.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes https://github.com/SUSE/spacewalk/issues/14828

  • DONE

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@juliogonzalez juliogonzalez merged commit 64db7b8 into uyuni-project:master May 10, 2021
@juliogonzalez juliogonzalez deleted the fix-almalinux-releasefile-parsing branch May 10, 2021 15:44
@ktsamis
Copy link
Contributor

ktsamis commented May 10, 2021

I confirm that this fixes the bug https://bugzilla.suse.com/show_bug.cgi?id=1185846

@paususe
Copy link
Contributor

paususe commented May 10, 2021

Thank you and sorry for breaking it O:-)

Bischoff pushed a commit to Bischoff/uyuni that referenced this pull request May 11, 2021
* fix product detection while bootstrapping RedHat like products (bsc#1185846)

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants