Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt tests: cleanup all remaining disk images #957

Merged
merged 1 commit into from May 13, 2019

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented May 10, 2019

What does this PR change?

Some disks images are left over in the default pool after the KVM or Xen tests. Ensure those are removed at the end of the test.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: test suite enhancement

  • DONE

Test coverage

  • No tests: tests fix

  • DONE

Links

  • DONE

Changelogs

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_lint_checkstyle"
  • Re-run test "java_pgsql_tests"
  • Re-run test "ruby_rubocop"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"

@cbosdo
Copy link
Contributor Author

cbosdo commented May 10, 2019

gitarro no changelog needed !!!

Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see nitpicks.

testsuite/documentation/cucumber-steps.md Outdated Show resolved Hide resolved
testsuite/features/minkvm_guests.feature Show resolved Hide resolved
Some disks are left over in the default pool. Ensure those are removed
at the end of the test.
@cbosdo cbosdo merged commit 2fbbba3 into uyuni-project:master May 13, 2019
@cbosdo cbosdo deleted the virt-test-cleanup branch May 13, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants