/rpg_dvs_ros

Use fixed-point arithmetic for time stamps #40

Merged
merged 2 commits into from Jun 28, 2017
+8 −4

Conversation

Reviewers

@eliasm eliasm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@morloy @eliasm
@morloy
Contributor

morloy commented Jun 27, 2017

We currently convert timestamps from int64 -> double -> int64 (ros::Time).
Introduces very small rounding errors.

morloy requested a review from eliasm Jun 27, 2017

@eliasm

eliasm approved these changes Jun 28, 2017
View changes

Thanks, lgtm. Would you mind changing this also for the DVS driver? https://github.com/uzh-rpg/rpg_dvs_ros/blob/master/dvs_ros_driver/src/driver.cpp#L250

@morloy
Contributor

morloy commented Jun 28, 2017

Fine?

@morloy morloy merged commit 6474994 into master Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment