Drop sprint/story/FR references from code and docs#152
Merged
Conversation
These citations pointed at sprint plans and a PRD living in a separate repo (aimx-docs), and the numbering rots: story IDs get renumbered and FR sections get rewritten. Future readers of this repo don't have that context, so the references just confuse. The technical content stays; only the cross-references go. Patterns stripped include `Sprint N SN-X:` banners, `(FR-X.Y)` parentheticals, `Hardening PRD §X.Y / S N-Z:` prefixes, and test-assertion strings citing retired sprint numbers. Book release notes and agent plugin READMEs drop "agent-integration Sprint N" qualifiers and `FR-49` citations — the design principle stays as plain prose.
# Conflicts: # .github/workflows/ci.yml # .github/workflows/release.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
// Sprint 2 S2-3: …prefixes,(FR-13b)parentheticals,Hardening PRD §6.4 / S3-1:citations,"S6-1 e2e test"fixture strings) go.docs/(separate repo, symlinked) is untouched — the sprint plan itself still lives there.Why
Sprint/story IDs and PRD FR numbers point at planning docs readers of this repo don't have open, and the numbering rots as sprints are renumbered or PRD sections rewritten. The in-code citations just confuse future readers. This change makes the code and user-facing docs read standalone.
Notable non-comment changes
tests/integration.rs: fixture email subject"S6-1 e2e test"→"end-to-end test"(matching assertion updated).src/agent_setup.rs: removed theassert!(text.contains("FR-50c"))check onaimx-primer.md; the surrounding/var/lib/aimx//inbox//sent/assertions remain.tests/integration.rs: five#[ignore = "requires root (Sprint 4 §6.5: ...)"]tokens →"requires root; MAILBOX-CRUD is root-only; ...".hook_templates_defaults.rstest reason string rewritten to describe the invariant directly (webhook template ordering) instead of citing the PRD section.Test plan
rg 'sprint|\bSprint\b|\bS[0-9]+[-.][0-9]+|FR-[0-9]'across tree (excludingdocs/,target/,.git/): zero hits.cargo fmt -- --check— clean in both crates.cargo build— clean.cargo clippy --all-targets -- -D warnings— clean in both crates.cargo test— 1344 passing. 1 pre-existing macOS-only failure (uds_authz::tests::lookup_unknown_uid_returns_none, caused by macOS mapping UID 4294967294 tonobody; aimx is Linux-only and CI runs ubuntu-latest).cd services/verifier && cargo test— 42 passing. 1 pre-existing macOS-only SMTP line-reader test failure; unrelated to this change (diff in that file is two comment-only edits).