Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/len/length/ s/cap/capacity/ to avoid builtin shadowing #1292

Merged
merged 1 commit into from Oct 1, 2018
Merged

s/len/length/ s/cap/capacity/ to avoid builtin shadowing #1292

merged 1 commit into from Oct 1, 2018

Conversation

quasilyte
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #1292 into master will decrease coverage by 0.03%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
- Coverage   74.31%   74.28%   -0.04%     
==========================================
  Files         254      254              
  Lines       11172    11172              
==========================================
- Hits         8303     8299       -4     
- Misses       2074     2078       +4     
  Partials      795      795
Impacted Files Coverage Δ
transport/internet/udp/hub.go 78.08% <100%> (ø) ⬆️
proxy/vmess/encoding/commands.go 59.52% <66.66%> (ø) ⬆️
transport/internet/websocket/connection.go 66.03% <0%> (-7.55%) ⬇️
common/crypto/chunk.go 90.27% <0%> (-5.56%) ⬇️
proxy/vmess/inbound/inbound.go 75.91% <0%> (-1.58%) ⬇️
common/log/logger.go 87.5% <0%> (ø) ⬆️
common/task/task.go 76.28% <0%> (+1.03%) ⬆️
transport/internet/http/hub.go 76.31% <0%> (+2.63%) ⬆️
common/buf/reader.go 78.2% <0%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091fa6a...0cf3599. Read the comment docs.

@VictoriaRaymond VictoriaRaymond merged commit 9a4624b into v2ray:master Oct 1, 2018
@quasilyte quasilyte deleted the quasilyte/builtinShadow branch October 1, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants