Invalid metadata cause vineyardd crash

[sighingnow]

Describe your problem

Creating metadata with invalid input (missing necessary fields) crash the vineyardd:

In [2]: client = vineyard.connect("/tmp/vineyard.sock")
In [3]: meta = vineyard.ObjectMeta()
In [4]: meta['typename'] = 'anbcde'
In [5]: meta = vineyard.ObjectMeta()
In [6]: meta['index'] = 1
In [7]: client.create_metadata(meta)
---------------------------------------------------------------------------
MetaTreeInvalidException                  Traceback (most recent call last)
<ipython-input-7-a614ac08fba3> in <module>
----> 1 client.create_metadata(meta)
MetaTreeInvalidException: Metatree invalid: No typename field
In [8]:

Vineyardd fails with the following traceback:

E20210904 09:10:23.606397 38891520 socket_server.cc:508] Metatree invalid: No typename field
0x00000001059C56BC: (SP:0x00007000025145E0) (vineyard::backtrace_on_terminate() + 0x12C)
0x00007FFF2045B307: (SP:0x0000700002514780) (std::__terminate(void (*)()) + 0x8)
0x00007FFF2045DBEB: (SP:0x00007000025147A0) (__cxa_get_exception_ptr + 0x0)
0x00007FFF2045DBB2: (SP:0x00007000025147C0) (__cxxabiv1::exception_cleanup_func(_Unwind_Reason_Code, _Unwind_Exception*) + 0x0)
0x00000001054E4DA2: (SP:0x0000700002514800) (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const& nlohmann::basic_json<std::__1::map, std::__1::vector, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, bool, long long, unsigned long long, double, std::__1::allocator, nlohmann::adl_serializer, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >::get_ref_impl<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, nlohmann::basic_json<std::__1::map, std::__1::vector, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, bool, long long, unsigned long long, double, std::__1::allocator, nlohmann::adl_serializer, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > >(nlohmann::basic_json<std::__1::map, std::__1::vector, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, bool, long long, unsigned long long, double, std::__1::allocator, nlohmann::adl_serializer, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >&) + 0x262)
0x0000000105495415: (SP:0x0000700002514960) (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const& nlohmann::basic_json<std::__1::map, std::__1::vector, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, bool, long long, unsigned long long, double, std::__1::allocator, nlohmann::adl_serializer, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > >::get_ref<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, 0>() + 0x15)
0x000000010564188D: (SP:0x0000700002514980) (vineyard::VineyardServer::CreateData(nlohmann::basic_json<std::__1::map, std::__1::vector, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, bool, long long, unsigned long long, double, std::__1::allocator, nlohmann::adl_serializer, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > const&, std::__1::function<vineyard::Status (vineyard::Status const&, unsigned long long, unsigned long long, unsigned long long)>) + 0x122D)
0x00000001054A095D: (SP:0x0000700002515400) (vineyard::SocketConnection::doCreateData(nlohmann::basic_json<std::__1::map, std::__1::vector, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, bool, long long, unsigned long long, double, std::__1::allocator, nlohmann::adl_serializer, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > const&) + 0xE1D)
0x0000000105493F81: (SP:0x0000700002515AE0) (vineyard::SocketConnection::processMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 0xE71)
0x00000001054C7A51: (SP:0x0000700002516160) (vineyard::SocketConnection::doReadBody()::$_1::operator()(boost::system::error_code, unsigned long) const + 0x291)
0x00000001054C7356: (SP:0x00007000025162E0) (boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>::operator()(boost::system::error_code const&, unsigned long, int) + 0x426)
0x00000001054CA182: (SP:0x0000700002516480) (boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>::operator()() + 0x62)
0x00000001054CA115: (SP:0x00007000025164B0) (void boost::asio::asio_handler_invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>&, ...) + 0x15)
0x00000001054CA0EF: (SP:0x00007000025164D0) (void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>, vineyard::SocketConnection::doReadBody()::$_1>(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>&, vineyard::SocketConnection::doReadBody()::$_1&) + 0x2F)
0x00000001054CA0B1: (SP:0x0000700002516500) (void boost::asio::detail::asio_handler_invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>, boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>*) + 0x21)
0x00000001054C9E2D: (SP:0x0000700002516520) (void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>&) + 0x2D)
0x00000001054C9B06: (SP:0x0000700002516550) (void boost::asio::detail::handler_work<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::asio::any_io_executor, void>::complete<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>&) + 0x36)
0x00000001054C93DC: (SP:0x0000700002516580) (boost::asio::detail::reactive_socket_recv_op<boost::asio::mutable_buffers_1, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::generic::stream_protocol, boost::asio::any_io_executor>, boost::asio::mutable_buffers_1, boost::asio::mutable_buffer const*, boost::asio::detail::transfer_all_t, vineyard::SocketConnection::doReadBody()::$_1>, boost::asio::any_io_executor>::do_complete(void*, boost::asio::detail::scheduler_operation*, boost::system::error_code const&, unsigned long) + 0x31C)
0x000000010544F866: (SP:0x00007000025167C0) (boost::asio::detail::scheduler_operation::complete(void*, boost::system::error_code const&, unsigned long) + 0x66)
0x000000010544D112: (SP:0x0000700002516800) (boost::asio::detail::scheduler::do_run_one(boost::asio::detail::conditionally_enabled_mutex::scoped_lock&, boost::asio::detail::scheduler_thread_info&, boost::system::error_code const&) + 0x6D2)
0x000000010544C523: (SP:0x0000700002516A40) (boost::asio::detail::scheduler::run(boost::system::error_code&) + 0x253)
0x000000010563B9FB: (SP:0x0000700002516C40) (boost::asio::io_context::run() + 0x11B)
0x000000010571FB19: (SP:0x0000700002516D20) (boost::_mfi::mf0<unsigned long, boost::asio::io_context>::operator()(boost::asio::io_context*) const + 0xC9)
0x000000010571FA27: (SP:0x0000700002516D70) (unsigned long boost::_bi::list1<boost::_bi::value<boost::asio::io_context*> >::operator()<unsigned long, boost::_mfi::mf0<unsigned long, boost::asio::io_context>, boost::_bi::list0>(boost::_bi::type<unsigned long>, boost::_mfi::mf0<unsigned long, boost::asio::io_context>&, boost::_bi::list0&, long) + 0x77)
0x000000010571F930: (SP:0x0000700002516DC0) (boost::_bi::bind_t<unsigned long, boost::_mfi::mf0<unsigned long, boost::asio::io_context>, boost::_bi::list1<boost::_bi::value<boost::asio::io_context*> > >::operator()() + 0xF0)
0x000000010571F7FD: (SP:0x0000700002516EA0) (decltype(std::__1::forward<boost::_bi::bind_t<unsigned long, boost::_mfi::mf0<unsigned long, boost::asio::io_context>, boost::_bi::list1<boost::_bi::value<boost::asio::io_context*> > > >(fp)()) std::__1::__invoke<boost::_bi::bind_t<unsigned long, boost::_mfi::mf0<unsigned long, boost::asio::io_context>, boost::_bi::list1<boost::_bi::value<boost::asio::io_context*> > > >(boost::_bi::bind_t<unsigned long, boost::_mfi::mf0<unsigned long, boost::asio::io_context>, boost::_bi::list1<boost::_bi::value<boost::asio::io_context*> > >&&) + 0x1D)
0x000000010571F795: (SP:0x0000700002516EC0) (void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, boost::_bi::bind_t<unsigned long, boost::_mfi::mf0<unsigned long, boost::asio::io_context>, boost::_bi::list1<boost::_bi::value<boost::asio::io_context*> > > >(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, boost::_bi::bind_t<unsigned long, boost::_mfi::mf0<unsigned long, boost::asio::io_context>, boost::_bi::list1<boost::_bi::value<boost::asio::io_context*> > > >&, std::__1::__tuple_indices<>) + 0x25)
0x000000010571E873: (SP:0x0000700002516EE0) (void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, boost::_bi::bind_t<unsigned long, boost::_mfi::mf0<unsigned long, boost::asio::io_context>, boost::_bi::list1<boost::_bi::value<boost::asio::io_context*> > > > >(void*) + 0x123)
0x00007FFF204988FC: (SP:0x0000700002516FC0) (_pthread_start + 0xE0)
backtrace: unhandled exception std::exception:what(): [json.exception.type_error.303] incompatible ReferenceType for get_ref, actual type is null

Additional context

Add any other context about the problem here.