From 3d512baee2136fbe1c5564f83ef635d113b83a48 Mon Sep 17 00:00:00 2001 From: umberto di fabrizio Date: Fri, 18 Apr 2025 11:06:06 +0200 Subject: [PATCH 1/3] Run tests on each PR --- .github/workflows/EVENT_merge_to_master.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/workflows/EVENT_merge_to_master.yml b/.github/workflows/EVENT_merge_to_master.yml index 1e3326249..dd9df7242 100644 --- a/.github/workflows/EVENT_merge_to_master.yml +++ b/.github/workflows/EVENT_merge_to_master.yml @@ -9,18 +9,22 @@ on: permissions: contents: read - id-token: write # Necessary for the generate documentation job + id-token: write # Necessary for the generate documentation job concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: true jobs: - run_tests: name: Run tests uses: ./.github/workflows/JOB_tests.yml + e2e_tests: + name: E2E Tests + uses: ./.github/workflows/JOB_e2e.yml + secrets: inherit + documentation: name: Documentation uses: ./.github/workflows/JOB_generate_documentation.yml @@ -30,18 +34,18 @@ jobs: contents: read warn_on_fail: - needs: [run_tests, documentation] + needs: [run_tests, e2e_tests, documentation] if: ${{ failure() }} name: Slack message us on fail uses: ./.github/workflows/JOB_slack_message.yml secrets: inherit with: at_team: true - icon: ':warning:' - message: 'Master is failing after a push event, please review at ${{ github.event.repository.html_url }}/actions/runs/${{ github.run_id }}' + icon: ":warning:" + message: "Master is failing after a push event, please review at ${{ github.event.repository.html_url }}/actions/runs/${{ github.run_id }}" success: - needs: [run_tests, documentation] + needs: [run_tests, e2e_tests, documentation] if: ${{ success() }} name: Success runs-on: ubuntu-latest @@ -64,4 +68,4 @@ jobs: repo: context.repo.repo, sha: context.sha, state: 'success' - }) \ No newline at end of file + }) From 9a15e9b235a17dc2f8a3ab1b174e85a8e15c7a35 Mon Sep 17 00:00:00 2001 From: umberto di fabrizio Date: Fri, 18 Apr 2025 11:06:18 +0200 Subject: [PATCH 2/3] Run e2e every time a PR is merged in master --- .github/workflows/JOB_tests.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/JOB_tests.yml b/.github/workflows/JOB_tests.yml index 5fcfbc67e..0970d8cc6 100644 --- a/.github/workflows/JOB_tests.yml +++ b/.github/workflows/JOB_tests.yml @@ -4,6 +4,8 @@ run-name: Tests on: workflow_call: + pull_request: + branches: [main, master] permissions: contents: read @@ -48,7 +50,7 @@ jobs: pip install wheel && \ pip install --upgrade setuptools && \ pip install --editable '.[test,ml,medical,dev, ocv]'" - + - name: Install ffmpeg (Ubuntu) if: matrix.os == 'ubuntu-latest' shell: bash From 9ffdf7db8de12c75c43fdc4648de1ba05b136707 Mon Sep 17 00:00:00 2001 From: umberto di fabrizio Date: Fri, 18 Apr 2025 11:12:44 +0200 Subject: [PATCH 3/3] Remove master concurrency --- .github/workflows/EVENT_merge_to_master.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/EVENT_merge_to_master.yml b/.github/workflows/EVENT_merge_to_master.yml index dd9df7242..418ec6e54 100644 --- a/.github/workflows/EVENT_merge_to_master.yml +++ b/.github/workflows/EVENT_merge_to_master.yml @@ -11,10 +11,6 @@ permissions: contents: read id-token: write # Necessary for the generate documentation job -concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - cancel-in-progress: true - jobs: run_tests: name: Run tests