[PY-664][PY-662] BUG: Rasters import for videos fails on darwin-py 0.8.54 #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owencjones
suggested changes
Jan 8, 2024
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
Some comments to consider.
darwin/importer/importer.py
Outdated
| for frame_index, _annotation in annotation.frames.items(): | ||
| _annotation_id = _annotation.id | ||
| if ( | ||
| frame_index in rl_dense_rle_ids_frames and |
Contributor
There was a problem hiding this comment.
I'd be tempted to break this down into a meaningfully named boolean
Member
Author
There was a problem hiding this comment.
Um, as there's only 1 unique if check like this now - does this still apply? happy to create a variable and write if variable block there instead something like:
variable = (if statement)
if variable:
...
What do you think?
saurbhc
requested review from
owencjones and
rslota
and removed request for
Nathanjp91 and
owencjones
rslota
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A customer hit an error with importing rasters 'VideoAnnotation' object has no attribute 'data' that I was able to reproduce on darwin-py 0.8.54 but imported successfully on 0.
Solution
Handle Raster Layer checks for
VideoAnnotationobject.Changelog
Support Raster Layer checks for
VideoAnnotationobject.