Add assign batch action SDK #765
Conversation
Nathanjp91
left a comment
Nathanjp91
left a comment
There was a problem hiding this comment.
LGTM. Shouldn't be any issues.
| dataset_ids: int | list[int], | ||
| assignee_id: int, | ||
| workflow_id: str, | ||
| filters: dict[str, UnknownType], |
There was a problem hiding this comment.
we have a datatype for this, JSONDict, which is basically a wrapper for dict[str, Any]. Nothing huge but good to keep consistent. It's in future data_objects I think?
There was a problem hiding this comment.
This is copy-pasted from the set_stage, but sure, I'll change it here.
| """ | ||
| Assign a user to all items matched by filters. | ||
| Args: |
There was a problem hiding this comment.
Check this parses with the doc generation tool.
|
|
||
| def assign(self, assignee_id: int, workflow_id: str | None = None) -> None: | ||
| if not assignee_id: | ||
| raise ValueError("Must specify assignee to assign items to") |
There was a problem hiding this comment.
If you don't need this to be a ValueError, this could be an assert.
There was a problem hiding this comment.
Urgh, I just merged this before I got email about your comments :(
But this code is copied from other similar functions, so that keeps it consistent with them anyway.
This PR adds "assign" batch action. It's largely copy-pasted "set_state" as it works the same way, just with users, not stages. It doesn't support "User" object as input, as I'm pretty sure we don't have one yet.
Example test: