From 1442c048691bf3ccb022fad810ced5fdf1988955 Mon Sep 17 00:00:00 2001 From: Leszek Swirski Date: Thu, 6 Mar 2025 11:12:05 +0100 Subject: [PATCH 1/4] Bump deploy action to v4 --- .github/workflows/update-api-docs.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/update-api-docs.yml b/.github/workflows/update-api-docs.yml index fcd35e0673..229d4b8186 100644 --- a/.github/workflows/update-api-docs.yml +++ b/.github/workflows/update-api-docs.yml @@ -44,12 +44,11 @@ jobs: run: | python update.py - name: Deploy - uses: JamesIves/github-pages-deploy-action@releases/v3 + uses: JamesIves/github-pages-deploy-action@releases/v4 with: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - SINGLE_COMMIT: true - BASE_BRANCH: main - BRANCH: gh-pages - FOLDER: dist - GIT_CONFIG_NAME: V8 API docs updater - GIT_CONFIG_EMAIL: v8-dev+api@googlegroups.com + single-commit: true + case-branch: main + branch: gh-pages + folder: dist + git-config-name: V8 API docs updater + git-config-email: v8-dev+api@googlegroups.com From 413a69aa41fef347023bbafc93736b476316a2d3 Mon Sep 17 00:00:00 2001 From: Leszek Swirski Date: Thu, 6 Mar 2025 11:48:55 +0100 Subject: [PATCH 2/4] Add write permission to workflow --- .github/workflows/update-api-docs.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/update-api-docs.yml b/.github/workflows/update-api-docs.yml index 229d4b8186..0e78392d8d 100644 --- a/.github/workflows/update-api-docs.yml +++ b/.github/workflows/update-api-docs.yml @@ -11,6 +11,8 @@ on: schedule: # Rebuild docs every day at 3am. - cron: '0 3 * * *' + permissions: + contents: write workflow_dispatch: jobs: From 2ec24620991a4ba2c9341dca66a6e5218e791525 Mon Sep 17 00:00:00 2001 From: Leszek Swirski Date: Thu, 6 Mar 2025 11:49:54 +0100 Subject: [PATCH 3/4] Fix permissions location in yaml --- .github/workflows/update-api-docs.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update-api-docs.yml b/.github/workflows/update-api-docs.yml index 0e78392d8d..08fccdf89c 100644 --- a/.github/workflows/update-api-docs.yml +++ b/.github/workflows/update-api-docs.yml @@ -11,10 +11,10 @@ on: schedule: # Rebuild docs every day at 3am. - cron: '0 3 * * *' - permissions: - contents: write workflow_dispatch: +permissions: + contents: write jobs: build: name: Build and update docs From a7eb9dafadd3c396f753dd72d827f41e45608139 Mon Sep 17 00:00:00 2001 From: Leszek Swirski Date: Fri, 7 Mar 2025 09:29:23 +0100 Subject: [PATCH 4/4] Fx typo --- .github/workflows/update-api-docs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update-api-docs.yml b/.github/workflows/update-api-docs.yml index 08fccdf89c..0f88a38f57 100644 --- a/.github/workflows/update-api-docs.yml +++ b/.github/workflows/update-api-docs.yml @@ -49,7 +49,7 @@ jobs: uses: JamesIves/github-pages-deploy-action@releases/v4 with: single-commit: true - case-branch: main + base-branch: main branch: gh-pages folder: dist git-config-name: V8 API docs updater