Skip to content
Permalink
Browse files

[turbofan] handle dead effect-phi control op in InferReceiverMaps

Add an early exit if the control op is Dead to prevent failing the
DCHECK.

BUG=chromium:797596, v8:5940, v8:3018
R=bmeurer@chromium.org, jarin@chromium.org

Change-Id: I6090380ea69c3205740b6c7a41d7c066d18d6a9f
Reviewed-on: https://chromium-review.googlesource.com/844978
Commit-Queue: Caitlin Potter <caitp@igalia.com>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50312}
  • Loading branch information...
caitp authored and Commit Bot committed Dec 27, 2017
1 parent 013e86b commit 007f90ba9b331e4d3a8186799b098bec9b521b0a
Showing with 32 additions and 1 deletion.
  1. +2 −1 src/compiler/node-properties.cc
  2. +30 −0 test/mjsunit/compiler/regress-797596.js
@@ -464,7 +464,8 @@ NodeProperties::InferReceiverMapsResult NodeProperties::InferReceiverMaps(
case IrOpcode::kEffectPhi: {
Node* control = GetControlInput(effect);
if (control->opcode() != IrOpcode::kLoop) {
DCHECK_EQ(IrOpcode::kMerge, control->opcode());
DCHECK(control->opcode() == IrOpcode::kDead ||
control->opcode() == IrOpcode::kMerge);
return kNoReceiverMaps;
}

@@ -0,0 +1,30 @@
// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Flags: --expose-gc --allow-natives-syntax
var notCallable;
function inferReceiverMapsInDeadCode() {
var obj = { func() {} };
gc();
function wrappedCode() { try { code(); } catch (e) {} }
function code() {
obj.a;
try {
Object.defineProperty(obj, "func", { get() {} });
} catch (neverCaught) {}
for (var i = 0; i < 1; i++) {
try {
notCallable(arguments[i]);
} catch (alwaysCaught) {}
}
}
wrappedCode();
try {
%OptimizeFunctionOnNextCall(wrappedCode);
wrappedCode();
} catch (e) {}
}
inferReceiverMapsInDeadCode();
inferReceiverMapsInDeadCode();
inferReceiverMapsInDeadCode();

0 comments on commit 007f90b

Please sign in to comment.
You can’t perform that action at this time.