Skip to content
Permalink
Browse files

[esnext] ship "hashbang" syntax

Turns --harmony-hashbang on by default.

Intent to ship: https://groups.google.com/d/msg/v8-dev/hlCVa_XZ3TM/UWjjyOq3FwAJ
ChromeStatus page: https://www.chromestatus.com/feature/5134505706782720

BUG=v8:8523
R=gsathya@chromium.org, mathias@chromium.org, adamk@chromium.org

Change-Id: I821f69e45eb0a63a3f49181e2b88b0bcd091af2c
Reviewed-on: https://chromium-review.googlesource.com/c/1486113
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Caitlin Potter <caitp@igalia.com>
Cr-Commit-Position: refs/heads/master@{#59847}
  • Loading branch information...
caitp authored and Commit Bot committed Feb 25, 2019
1 parent 5c4dd9f commit 0cd67eb7c57e109aa4cbc8b8bdff6b9eaf8c1286
Showing with 27 additions and 27 deletions.
  1. +4 −4 src/flag-definitions.h
  2. +23 −23 test/test262/test262.status
@@ -213,9 +213,8 @@ DEFINE_IMPLICATION(harmony_private_methods, harmony_private_fields)
#endif

// Features that are complete (but still behind --harmony/es-staging flag).
#define HARMONY_STAGED_BASE(V) \
V(harmony_numeric_separator, "harmony numeric separator between digits") \
V(harmony_hashbang, "harmony hashbang syntax")
#define HARMONY_STAGED_BASE(V) \
V(harmony_numeric_separator, "harmony numeric separator between digits")

#ifdef V8_INTL_SUPPORT
#define HARMONY_STAGED(V) \
@@ -239,7 +238,8 @@ DEFINE_IMPLICATION(harmony_private_methods, harmony_private_fields)
V(harmony_string_matchall, "harmony String.prototype.matchAll") \
V(harmony_object_from_entries, "harmony Object.fromEntries()") \
V(harmony_await_optimization, "harmony await taking 1 tick") \
V(harmony_private_fields, "harmony private fields in class literals")
V(harmony_private_fields, "harmony private fields in class literals") \
V(harmony_hashbang, "harmony hashbang syntax")

#ifdef V8_INTL_SUPPORT
#define HARMONY_SHIPPING(V) \
@@ -555,29 +555,29 @@
'language/expressions/prefix-increment/eval-nostrict': [SKIP],

# https://bugs.chromium.org/p/v8/issues/detail?id=8850
'language/comments/hashbang/escaped-bang-041': [FAIL],
'language/comments/hashbang/escaped-bang-u0021': [FAIL],
'language/comments/hashbang/escaped-bang-u21': [FAIL],
'language/comments/hashbang/escaped-bang-x21': [FAIL],
'language/comments/hashbang/escaped-hash-043': [FAIL],
'language/comments/hashbang/escaped-hash-u0023': [FAIL],
'language/comments/hashbang/escaped-hash-u23': [FAIL],
'language/comments/hashbang/escaped-hash-x23': [FAIL],
'language/comments/hashbang/escaped-hashbang': [FAIL],
'language/comments/hashbang/eval': [FAIL],
'language/comments/hashbang/eval-indirect': [FAIL],
'language/comments/hashbang/module': [FAIL],
'language/comments/hashbang/multi-line-comment': [FAIL],
'language/comments/hashbang/no-line-separator': [FAIL],
'language/comments/hashbang/not-empty': [FAIL],
'language/comments/hashbang/preceding-directive-prologue': [FAIL],
'language/comments/hashbang/preceding-directive-prologue-sc': [FAIL],
'language/comments/hashbang/preceding-empty-statement': [FAIL],
'language/comments/hashbang/preceding-hashbang': [FAIL],
'language/comments/hashbang/preceding-line-comment': [FAIL],
'language/comments/hashbang/preceding-multi-line-comment': [FAIL],
'language/comments/hashbang/preceding-whitespace': [FAIL],
'language/comments/hashbang/use-strict': [FAIL],
'language/comments/hashbang/escaped-bang-041': [SKIP],
'language/comments/hashbang/escaped-bang-u0021': [SKIP],
'language/comments/hashbang/escaped-bang-u21': [SKIP],
'language/comments/hashbang/escaped-bang-x21': [SKIP],
'language/comments/hashbang/escaped-hash-043': [SKIP],
'language/comments/hashbang/escaped-hash-u0023': [SKIP],
'language/comments/hashbang/escaped-hash-u23': [SKIP],
'language/comments/hashbang/escaped-hash-x23': [SKIP],
'language/comments/hashbang/escaped-hashbang': [SKIP],
'language/comments/hashbang/eval': [SKIP],
'language/comments/hashbang/eval-indirect': [SKIP],
'language/comments/hashbang/module': [SKIP],
'language/comments/hashbang/multi-line-comment': [SKIP],
'language/comments/hashbang/no-line-separator': [SKIP],
'language/comments/hashbang/not-empty': [SKIP],
'language/comments/hashbang/preceding-directive-prologue': [SKIP],
'language/comments/hashbang/preceding-directive-prologue-sc': [SKIP],
'language/comments/hashbang/preceding-empty-statement': [SKIP],
'language/comments/hashbang/preceding-hashbang': [SKIP],
'language/comments/hashbang/preceding-line-comment': [SKIP],
'language/comments/hashbang/preceding-multi-line-comment': [SKIP],
'language/comments/hashbang/preceding-whitespace': [SKIP],
'language/comments/hashbang/use-strict': [SKIP],

######################## NEEDS INVESTIGATION ###########################

0 comments on commit 0cd67eb

Please sign in to comment.
You can’t perform that action at this time.