Please sign in to comment.
MIPS: Changed "marked" nops to use sll(zero_reg, at, type).
We use marking bits in nops (in the 'sa' field) for debug markers, and for some IC stuff. A normal NOP in mips is sll(zero_reg, zero_reg, 0), where the 0 is a 5 bit immediate field in 'sa'. See enum NopMarkerTypes at around line 654 of assembler-mips.h The problem is that these markers use encodings that are reserved for the 'ssnop' and 'ehb' instructions. These are instructions used for hazard barriers. It does not break anything, but it will slow things down a little bit as some pipeline stages are cleared, etc. This commit changes the "marked" NOPs to sll(zero_reg, at, type) instructions, which is also a NOP operation on MIPS. BUG= TEST= Review URL: https://codereview.chromium.org/10990110 Patch from Akos Palfi <email@example.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@12657 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
- Loading branch information...
Showing with 15 additions and 9 deletions.