From 89b3702c92b0dfe8737eda94cedb1ec715b30fc7 Mon Sep 17 00:00:00 2001 From: Shu-yu Guo Date: Thu, 31 Aug 2023 15:59:04 -0700 Subject: [PATCH] Reland^2 "[iterator-helpers] Unship due to incompat" This is a reland of commit bab67985346dbc0d566391ad561537b4554455b4 Change since reland: A second breakage reported in chromium:1480783 Original change's description: > Reland "[iterator-helpers] Unship due to incompat" > > This is a reland of commit 1a22cf9896d682a9dfca589f92ed97c7f875b8a2 > > Change since revert: I mistakenly thought part of the finch > kill-switch playbook is to keep it enabled on ToT. It's actually > the opposite. > > Original change's description: > > [iterator-helpers] Unship due to incompat > > > > Bug: chromium:1474613, v8:13558 > > Change-Id: Iccba26e5cd5dc1787172c78b6e4f6889ef67fcea > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4834350 > > Reviewed-by: Adam Klein > > Commit-Queue: Shu-yu Guo > > Cr-Commit-Position: refs/heads/main@{#89741} > > Bug: chromium:1474613, v8:13558 > Change-Id: Idc421a114303f036622bff681c9fa252c9110b9d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4843761 > Commit-Queue: Rezvan Mahdavi Hezaveh > Auto-Submit: Shu-yu Guo > Commit-Queue: Shu-yu Guo > Reviewed-by: Rezvan Mahdavi Hezaveh > Cr-Commit-Position: refs/heads/main@{#89800} Bug: chromium:1474613, v8:13558 Change-Id: Ia933c874508f1ec10ea4718c6378858cd5bec8f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4854732 Reviewed-by: Rezvan Mahdavi Hezaveh Auto-Submit: Shu-yu Guo Commit-Queue: Rezvan Mahdavi Hezaveh Cr-Commit-Position: refs/heads/main@{#89905} --- src/flags/flag-definitions.h | 6 +++--- test/mjsunit/es6/iterator-prototype.js | 2 ++ test/mozilla/mozilla.status | 1 + 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index 6e667d1d2277..37f78d340dd7 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -278,7 +278,8 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features") // Features that are complete (but still behind the --harmony flag). #define HARMONY_STAGED_BASE(V) \ - V(harmony_set_methods, "harmony Set Methods") + V(harmony_set_methods, "harmony Set Methods") \ + V(harmony_iterator_helpers, "JavaScript iterator helpers") #define JAVASCRIPT_STAGED_FEATURES_BASE(V) \ V(js_promise_withresolvers, "Promise.withResolvers") @@ -303,8 +304,7 @@ DEFINE_WEAK_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab) V(harmony_regexp_unicode_sets, "harmony RegExp Unicode Sets") \ V(harmony_json_parse_with_source, "harmony json parse with source") \ V(harmony_rab_gsab_transfer, "harmony ArrayBuffer.transfer") \ - V(harmony_array_grouping, "harmony array grouping") \ - V(harmony_iterator_helpers, "JavaScript iterator helpers") + V(harmony_array_grouping, "harmony array grouping") #define JAVASCRIPT_SHIPPING_FEATURES_BASE(V) diff --git a/test/mjsunit/es6/iterator-prototype.js b/test/mjsunit/es6/iterator-prototype.js index 82277d981702..496b67de122a 100644 --- a/test/mjsunit/es6/iterator-prototype.js +++ b/test/mjsunit/es6/iterator-prototype.js @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// Flags: --harmony-iterator-helpers + var arrayIteratorPrototype = [].entries().__proto__; var iteratorPrototype = arrayIteratorPrototype.__proto__; diff --git a/test/mozilla/mozilla.status b/test/mozilla/mozilla.status index 724252d34e0c..aacb4e223352 100644 --- a/test/mozilla/mozilla.status +++ b/test/mozilla/mozilla.status @@ -546,6 +546,7 @@ # Uses Mozilla-specific QName, XML, XMLList and Iterator. 'js1_5/Regress/regress-407323': [FAIL_OK], + 'js1_5/Regress/regress-407957': [FAIL_OK], # Relies on JavaScript 1.2 / 1.3 deprecated features.