Skip to content
Permalink
Browse files

[compiler] Prevent dependency invalidation in release mode.

This makes sure that breaking dependencies during compilation is also
caught properly in release mode (not only in debug mode). When this
happens the generated code would be invalid from the beginning and we
need to prevent using such code.

R=bmeurer@chromium.org
BUG=chromium:794394,chromium:786723

Change-Id: I76fd85786c16807389f69a9c44b9f893004b1c6f
Reviewed-on: https://chromium-review.googlesource.com/826635
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50105}
  • Loading branch information...
Michael Starzinger Commit Bot
Michael Starzinger authored and Commit Bot committed Dec 14, 2017
1 parent ccca173 commit a90503d8a9526f9a3e3df4e24e68c8aea1c74f14
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/compiler.cc
@@ -114,8 +114,8 @@ CompilationJob::Status CompilationJob::FinalizeJob(Isolate* isolate) {
DCHECK(ThreadId::Current().Equals(isolate->thread_id()));
DisallowCodeDependencyChange no_dependency_change;
DisallowJavascriptExecution no_js(isolate);
DCHECK(!compilation_info()->dependencies() ||
!compilation_info()->dependencies()->HasAborted());
CHECK(!compilation_info()->dependencies() ||
!compilation_info()->dependencies()->HasAborted());

// Delegate to the underlying implementation.
DCHECK_EQ(state(), State::kReadyToFinalize);

0 comments on commit a90503d

Please sign in to comment.
You can’t perform that action at this time.