Permalink
Browse files

[array] Revert "Implement Array.p.sort in Torque"

This CL is a manual revert of the Array.p.sort Torque QuickSort
implementation.

The plan is to ship TimSort in either Chromium 69 or 70 and not ship
Torque-QuickSort at all (to keep disruption to a minimum). For this
reason we revert back to the implementation in array.js.

R=jgruber@chromium.org

Bug: chromium:859809, v8:7382
Change-Id: I92eb70408883f51d98311e78642f554316bc1e76
Reviewed-on: https://chromium-review.googlesource.com/1124334
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#54166}
  • Loading branch information...
Imasius authored and Commit Bot committed Jul 3, 2018
1 parent 08d11cd commit f7bad08397d922d7fe0bc10624f517c6f5412595
Showing with 16 additions and 613 deletions.
  1. +0 −2 src/bootstrapper.cc
  2. +2 −607 src/builtins/array-sort.tq
  3. +0 −1 src/debug/debug-evaluate.cc
  4. +13 −2 src/js/array.js
  5. +1 −1 test/message/fail/non-alphanum.out
@@ -1730,8 +1730,6 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
1, false);
SimpleInstallFunction(isolate_, proto, "slice",
Builtins::kArrayPrototypeSlice, 2, false);
SimpleInstallFunction(isolate_, proto, "sort",
Builtins::kArrayPrototypeSort, 1, false);
if (FLAG_enable_experimental_builtins) {
SimpleInstallFunction(isolate_, proto, "splice",
Builtins::kArraySpliceTorque, 2, false);
Oops, something went wrong.

0 comments on commit f7bad08

Please sign in to comment.