Permalink
Commits on Mar 27, 2018
  1. [cleanup] Delete test with obsolete flag

    fhinkel authored and Commit Bot committed Mar 27, 2018
    --cleanup-code-caches-at-gc flag was removed in
    https://chromium.googlesource.com/v8/v8/+/b8b25e1c27b6634b764245671b5fcaacb19278bf,
    rendering the test obsolete.
    
    Change-Id: I34331d230102924899c89d3330379df51a489029
    Reviewed-on: https://chromium-review.googlesource.com/980937
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52239}
  2. [api] Deprecate SetNamedPropertyHandler

    fhinkel authored and Commit Bot committed Mar 26, 2018
    I replaced usages in Chromium and other embedders. I think we can safely
    deprecate and soon remove.
    
    Drive-by fix: Fixed some typos.
    
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: Ia8e35adb2abebed3966403af61eda1ede319e5c3
    Reviewed-on: https://chromium-review.googlesource.com/980452
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52236}
Commits on Feb 12, 2018
  1. [heap-profiler] Make ownership for samples explicit

    fhinkel authored and Commit Bot committed Feb 9, 2018
    Change-Id: Ic0e513e61e3bd1a8ac8f06a1f81c27d35a7d29af
    Reviewed-on: https://chromium-review.googlesource.com/911249
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51253}
Commits on Feb 8, 2018
  1. [heap-profiler] Use unique ptr for snapshots for explicit ownership

    fhinkel authored and Commit Bot committed Feb 8, 2018
    Implement empty desctructor because of the forward declarations.
    
    Change-Id: I56af92d7ded44b6fcd3582d1e3a10e9bb5cb1296
    Reviewed-on: https://chromium-review.googlesource.com/905671
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51180}
Commits on Feb 6, 2018
  1. [cpu-profiler] Use unique pointers for clearer ownership

    fhinkel authored and Commit Bot committed Feb 6, 2018
    Use unique pointers in vectors of current and finished profiles.
    
    Change-Id: Ifb78f7d3804e9883062741fd4e4e31109965d501
    Reviewed-on: https://chromium-review.googlesource.com/898984
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51113}
Commits on Feb 5, 2018
  1. [cpu-profiler] Use unique pointer for line info

    fhinkel authored and Commit Bot committed Feb 2, 2018
    Change-Id: Ia1289985fa715ce4de66bec91675279c203afa36
    Reviewed-on: https://chromium-review.googlesource.com/897811
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51091}
Commits on Feb 2, 2018
  1. [cleanup] Simplify loop over map

    fhinkel authored and Commit Bot committed Feb 2, 2018
    Change-Id: Ibda6dc025e9a1584480154fba63ecf3c7b51394b
    Reviewed-on: https://chromium-review.googlesource.com/897765
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51068}
  2. [cpu-profiler] Use unique_ptrs in the inline stack

    fhinkel authored and Commit Bot committed Feb 1, 2018
    Small cleanup.
    
    Change-Id: I80f7ede4de1aed3e37c2b20cb3706cb9ef3aa9be
    Reviewed-on: https://chromium-review.googlesource.com/897810
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51056}
Commits on Jan 4, 2018
  1. Revert "[api] Prefer Descriptor interceptor over Getter in GetPropert…

    fhinkel authored and Commit Bot committed Jan 4, 2018
    …yAttributes"
    
    This reverts commit d5fbf7c.
    
    Reason for revert: Performance regression, see https://bugs.chromium.org/p/chromium/issues/detail?id=798279
    
    Original change's description:
    > [api] Prefer Descriptor interceptor over Getter in GetPropertyAttributes
    > 
    > Also fix GetPropertyDescriptorWithInterceptor so that it only calls the
    > interceptor once.
    > 
    > R=​ahaas@chromium.org, franzih@chromium.org
    > 
    > Bug: node:17480, node:17481
    > Change-Id: I2c3813f80df2962ec909bae7267884ce0b8ccbef
    > Reviewed-on: https://chromium-review.googlesource.com/816515
    > Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    > Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#50260}
    
    TBR=timothygu99@gmail.com,ahaas@chromium.org,franzih@chromium.org,sergiyb@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: node:17480, node:17481
    Change-Id: I4997e0f3a330d719026e56dd83c1bb999b986bcf
    Reviewed-on: https://chromium-review.googlesource.com/850355
    Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50362}
Commits on Jan 3, 2018
  1. [cpu-profiler] Fix script name when recording inlining info

    fhinkel authored and Commit Bot committed Jan 3, 2018
    Use the script name from the shared function info to create an
    inline entry. Otherwise functions are attributed to the wrong file
    in the CpuProfileNode.
    
    See googleapis/cloud-profiler-nodejs#89
    
    Bug: v8:7203, v8:7241
    Change-Id: I8ea31943741770e6611275a9c93375922b934547
    Reviewed-on: https://chromium-review.googlesource.com/848093
    Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50339}
Commits on Jan 2, 2018
  1. Revert "[cpu-profiler] Fix script name when recording inlining info"

    fhinkel authored and Commit Bot committed Jan 2, 2018
    This reverts commit c500aa9.
    
    Reason for revert: Breaks V8 Linux64 - gyp
    
    Original change's description:
    > [cpu-profiler] Fix script name when recording inlining info
    > 
    > Use the script name from the shared function info to create an
    > inline entry. Otherwise functions are attributed to the wrong file
    > in the CpuProfileNode.
    > 
    > See googleapis/cloud-profiler-nodejs#89
    > 
    > 
    > Bug: v8:7203, v8:7241
    > Change-Id: I7a7524ad68a295efd35ef94295cd48f823376e07
    > Reviewed-on: https://chromium-review.googlesource.com/845624
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#50324}
    
    TBR=jarin@chromium.org,franzih@chromium.org
    
    Change-Id: I5876d24723bb6bd20854db91a579485b07313a69
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7203, v8:7241
    Reviewed-on: https://chromium-review.googlesource.com/846771
    Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50325}
  2. [cpu-profiler] Fix script name when recording inlining info

    fhinkel authored and Commit Bot committed Dec 29, 2017
    Use the script name from the shared function info to create an
    inline entry. Otherwise functions are attributed to the wrong file
    in the CpuProfileNode.
    
    See googleapis/cloud-profiler-nodejs#89
    
    
    Bug: v8:7203, v8:7241
    Change-Id: I7a7524ad68a295efd35ef94295cd48f823376e07
    Reviewed-on: https://chromium-review.googlesource.com/845624
    Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50324}
Commits on Dec 29, 2017
  1. [profiler] Delete unused NodesPair

    fhinkel authored and Commit Bot committed Dec 29, 2017
    Cleanup, delete unused struct.
    
    Bug: 
    Change-Id: I4ea5e81d6d0711d7cf3fdd279f8b0d136bcd6db3
    Reviewed-on: https://chromium-review.googlesource.com/846760
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: Michael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50319}
Commits on Dec 5, 2017
  1. [profiler] Log code-source-info for each function

    fhinkel authored and Commit Bot committed Dec 5, 2017
    We were returning too early. Don't double-log the script, but log all
    source-code-infos within it.
    
    Bug: v8:7018
    Change-Id: Icd29905ee1ae3444e30760cae0b0a18b55440335
    Reviewed-on: https://chromium-review.googlesource.com/808165
    Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49861}
Commits on Nov 8, 2017
  1. [profview] Use identity operator

    fhinkel authored and Commit Bot committed Nov 6, 2017
    Use !== instead of !=.
    
    Bug: 
    Change-Id: I3f8127d54b80973f9ea7bb6ddf25afd928cb3045
    Reviewed-on: https://chromium-review.googlesource.com/753733
    Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49210}
Commits on Nov 6, 2017
  1. [cleanup] Fix typos

    fhinkel authored and Commit Bot committed Nov 6, 2017
    Bug: 
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I9df5beca6444a42aa35c624760265a3cc02182b6
    Reviewed-on: https://chromium-review.googlesource.com/753450
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49135}
Commits on Nov 3, 2017
  1. [cleanup] Use range based for loop

    fhinkel authored and Commit Bot committed Nov 3, 2017
    Bug: 
    Change-Id: I5be4eabfc61f885f380fbec27dc537ed5d031493
    Reviewed-on: https://chromium-review.googlesource.com/753084
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49100}
  2. [cleanup] Fix code style

    fhinkel authored and Commit Bot committed Nov 3, 2017
    Bug: 
    Change-Id: I341ab2833896afcb1f97a6d4c3af3afb12a26b8a
    Reviewed-on: https://chromium-review.googlesource.com/753083
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49096}
Commits on Oct 18, 2017
  1. [api] Intercept DefineProperty after Descriptor query

    fhinkel authored and Commit Bot committed Oct 18, 2017
    Analog to other interceptors, intercept the DefineProperty
    call only after obtaining the property descriptor.
    
    This behavior allows us to mirror calls on a sandboxed object
    as it is needed in Node. See for example
    nodejs/node#13265
    
    Bug: 
    Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3
    Reviewed-on: https://chromium-review.googlesource.com/725295
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48683}
Commits on Oct 17, 2017
  1. [type-profile] Use vector list from isolate

    fhinkel authored and Commit Bot committed Oct 17, 2017
    Instead of re-iterating over the heap all the time, use the
    list of feedback vectors on the isolate. This also avoids GC of vectors.
    
    Bug: v8:5935
    Change-Id: I0bb96fcf2b0feb9856e9806f812188de1fc7b37e
    Reviewed-on: https://chromium-review.googlesource.com/668396
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48643}
Commits on Sep 14, 2017
  1. [type-profile] Use shared_ptr instead of raw pointer

    fhinkel authored and Commit Bot committed Sep 11, 2017
    If TypeProfile goes out of scope, ScriptData and Entry still rely on
    TypeProfiles's type_profile_. Make type_profile_ a shared_ptr owned by all
    three classes to prevent use after free.
    
    Bug: v8:5933
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: Ida7d66dadc17a816cf4439a25e6f714edccffa2c
    Reviewed-on: https://chromium-review.googlesource.com/659937
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48013}
  2. [cleanup] Delete default destructor.

    fhinkel authored and Commit Bot committed Sep 11, 2017
    Bug: 
    Change-Id: I597b2c1067e309c2545daef4223b3b883d15a6c1
    Reviewed-on: https://chromium-review.googlesource.com/657761
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48011}
Commits on Sep 13, 2017
  1. [test] Fixing incorrectly capitalised regexps

    fhinkel authored and Commit Bot committed Sep 13, 2017
    Bug: 
    Change-Id: I32faae50c786b67599a68840baad478ce81c1398
    Reviewed-on: https://chromium-review.googlesource.com/663544
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47989}
Commits on Sep 11, 2017
  1. [coverage] Use shared_ptr instead of raw pointer

    fhinkel authored and Commit Bot committed Sep 9, 2017
    If Coverage goes out of scope, ScriptData, FunctionData, or BlockData still rely on 
    Coverage's coverage_. Make coverage_ a shared_ptr owned by all four classes. 
    
    Bug: 
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: Ifab5d05184cc5db0fd0a935254b967286295e63f
    Reviewed-on: https://chromium-review.googlesource.com/657381
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47938}
  2. [type-profile] Move type profile to its own files

    fhinkel authored and Commit Bot committed Sep 8, 2017
    Bug: v8:5933
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: If7d69844a309285ff53edb38688c3c647217fea2
    Reviewed-on: https://chromium-review.googlesource.com/657379
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47937}
Commits on Sep 8, 2017
  1. [type-profile] Incorporate into inspector protocol.

    fhinkel authored and Commit Bot committed Sep 8, 2017
    JavaScript is a dynamically typed language. But most code is 
    written with fixed types in mind. When debugging JavaScript, 
    it is helpful to know the types of variables and parameters 
    at runtime. It is often hard to infer types for complex code. 
    Type profiling provides this information at runtime.
    
    Node.js uses the inspector protocol. This CL allows Node.js users 
    to access and analyse type profile for via Node modules or the
    in-procress api. Type Profile helps developers to analyze 
    their code for correctness and performance.  
    
    Design doc: https://docs.google.com/a/google.com/document/d/1O1uepXZXBI6IwiawTrYC3ohhiNgzkyTdjn3R8ysbYgk/edit?usp=sharing
    
    Add `takeTypeProfile` to the inspector protocol. It returns a list
    of TypeProfileForScripts, which in turn contains the type profile for
    each function. We can use TypeProfile data to annotate JavaScript code. 
    
    Sample script with data from TypeProfile:
    function f(/*Object, number, undefined*/a, 
               /*Array, number, null*/b, 
               /*boolean, Object, symbol*/c) {
      return 'bye';
    /*string*/};
    f({}, [], true);
    f(3, 2.3, {a: 42});
    f(undefined, null, Symbol('hello'));/*string*/
    
    Bug: v8:5933
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I626bfb886b752f90b9c86cc6953601558b18b60d
    Reviewed-on: https://chromium-review.googlesource.com/508588
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Reviewed-by: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47920}
Commits on Sep 7, 2017
  1. [api] Disable copy for PropertyCallbackArguments

    fhinkel authored and Commit Bot committed Sep 6, 2017
    Bug: 
    Change-Id: I3a97b303bcb4cbb4835fb5de8c55a21eaaa93504
    Reviewed-on: https://chromium-review.googlesource.com/649615
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47868}
Commits on Sep 6, 2017
  1. [api] Do not re-use PropertyCallbackArguments

    fhinkel authored and Commit Bot committed Sep 5, 2017
    args.Call() sets a return value on args. Do not reuse the
    same args object, otherwise the return value might be from the previous Call().
    
    Bug: v8:6627
    Change-Id: I05fb2d8036f94908a492d46cc5d746bc145e419e
    Reviewed-on: https://chromium-review.googlesource.com/651407
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47843}
Commits on Sep 5, 2017
  1. Reland "[api] Add test for EnumeratorCallback and for...in."

    fhinkel authored and Commit Bot committed Aug 10, 2017
    This is a reland of 56772de
    Original change's description:
    > [api] Add test for EnumeratorCallback and for...in.
    > 
    > If a QueryCallback is present, it is used to
    > filter the result from the EnumeratorCallback for
    > enumerable properties. This tests assures that
    > for...in loops work correctly with these interceptors.
    > 
    > Bug: v8:6627
    > Change-Id: I1e568beac1e138a330034492b87bd49c22e0c804
    > Reviewed-on: https://chromium-review.googlesource.com/609982
    > Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    > Reviewed-by: Adam Klein <adamk@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#47445}
    
    TBR=adamk@chromium.org
    
    Bug: v8:6627
    Change-Id: I509016a879d175b01f7cc7918758354fe0df8ebf
    Reviewed-on: https://chromium-review.googlesource.com/650906
    Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47838}
  2. [api] Use query interceptor in Object.keys().

    fhinkel authored and Commit Bot committed Sep 4, 2017
    The V8 API provides interceptors. They are not part of the
    EcmaScript specification. But their behavior should be consistent.
    For example, when an EnumeratorInterceptor is defined, Object.keys(),
    Object.entries(), and Object.values() should all have the
    same number of entries.
    
    This CL creates consistent behavior among these
    functions. If a QueryCallback is present, it is used to
    filter the result from the EnumeratorCallback for
    enumerable properties.
    
    Bug: v8:6627
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I4f4271ddeb99a5e85918148c5033923c149b9468
    Reviewed-on: https://chromium-review.googlesource.com/649786
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47831}
Commits on Sep 4, 2017
  1. [builtins] Throw when setting typed arrays from large sources

    fhinkel authored and Commit Bot committed Sep 4, 2017
    When setting a typed array from an array like object, the 
    length of the source can only be converted to a unit32 if 
    it is not too large. 
    
    Bug: v8:6704, chromium:761654
    Change-Id: I8f89aa348093d8bd4d54aa16d6b5f255d3cb7adc
    Reviewed-on: https://chromium-review.googlesource.com/648976
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47798}
Commits on Sep 1, 2017
  1. [builtins] Move TypedArrayPrototypeSet to builtins

    fhinkel authored and Commit Bot committed Aug 31, 2017
    Bug: v8:6704
    Change-Id: I77388b91061f934943a707a645080dfdcf481836
    Reviewed-on: https://chromium-review.googlesource.com/645951
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47756}
Commits on Aug 31, 2017
  1. [runtime] Use scoped enum

    fhinkel authored and Commit Bot committed Aug 31, 2017
    Change-Id: Ibfc5dcd012073f9e3e3b000a90eab706b29189d8
    Reviewed-on: https://chromium-review.googlesource.com/646329
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47750}
  2. [runtime] Port TypedArrayPrototypeSet to C++

    fhinkel authored and Commit Bot committed Aug 31, 2017
    Bug: v8:6704
    Change-Id: If636bdd682d76a6d58d36fc9bfbf1302a32468ab
    Reviewed-on: https://chromium-review.googlesource.com/641671
    Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47732}
Commits on Aug 29, 2017
  1. [runtime] Delete extra variables

    fhinkel authored and Commit Bot committed Aug 29, 2017
    No need to reassign those JSTypedArrays.
    
    Bug: v8:6704
    Change-Id: Ide1f8bb119285b57ea85b8e710358c917244f801
    Reviewed-on: https://chromium-review.googlesource.com/641474
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47693}