Skip to content
Permalink
Branch: master
Commits on Jun 11, 2019
  1. [wasm] use standard WebAssembly stack trace format

    quantum5 authored and Commit Bot committed Jun 6, 2019
    Currently, in wasm-function stack traces, v8 displays the decimal offset
    from the start of the function. However, the WebAssembly WebAPI
    specification says that it should be a hex offset into the module.
    
    This change makes the stack trace display with hex module offsets, as
    well as fixing all the unit tests that depended on the old behaviour.
    
    R=fgm@chromium.org, titzer@chromium.org, yangguo@chromium.org
    
    Bug: v8:9172
    Change-Id: I73737a319a42dd665521ab8a4b825199ae11c87f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1646846
    Reviewed-by: Ben Titzer <titzer@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Commit-Queue: Guanzhong Chen <gzchen@google.com>
    Cr-Commit-Position: refs/heads/master@{#62103}
You can’t perform that action at this time.