Skip to content
Branch: master
Find file History
Francis McCabe Commit Bot
Francis McCabe and Commit Bot Revert "Reland "[torque] move class tests to unittests""
This reverts commit c33a1ef.

Reason for revert: fails win32 test:
https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20nosnap%20-%20shared/33658

Original change's description:
> Reland "[torque] move class tests to unittests"
> 
> This is a reland of f589d56
> 
> Now with an ASAN-container-overflow false positive workaround:
> Somehow ASAN was unhappy about a simple
> std::vector<std::string>::push_back.
> Increasing the std::vector capacity before doing the push_back
> strangely fixes the problem.
> 
> Original change's description:
> > [torque] move class tests to unittests
> >
> > This avoids the generation of fake external classes.
> >
> > Bug: v8:7793
> > Change-Id: I9744b299d3ec474d72b298b4f6143f95e345d1d9
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625991
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#61778}
> 
> TBR: szuend@chromium.org, sigurds@chromium.org
> Bug: v8:7793
> Change-Id: Ifa1958e4d6e850ba27632aa95c7efaf5ca4bfefa
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627970
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#61807}

TBR=sigurds@chromium.org,tebbi@chromium.org,szuend@chromium.org

Change-Id: I079e3ccf2c7a4778e3e6aabee85313ab5a070ee3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7793
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1626834
Reviewed-by: Francis McCabe <fgm@chromium.org>
Commit-Queue: Francis McCabe <fgm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61808}
Latest commit 0ef1982 May 23, 2019
Permalink
Type Name Latest commit message Commit time
..
Failed to load latest commit information.
ls [torque] More flexibel and uniform error reporting May 21, 2019
OWNERS Add OWNERS for src/torque May 15, 2019
ast.h [torque] explicit exports of macros to CSA May 20, 2019
cfg.cc [torque] compute fixed-point when typing Torque IR Nov 13, 2018
cfg.h [torque] compute fixed-point when typing Torque IR Nov 13, 2018
constants.h [torque] Generate class templates from Torque May 16, 2019
contextual.h [torque] More flexibel and uniform error reporting May 21, 2019
csa-generator.cc Port proxy trap GetProperty to Torque Apr 24, 2019
csa-generator.h Reland "[Torque] Add source positions for Torque files" Feb 18, 2019
declarable.cc [torque] Make torque declarations order independent May 7, 2019
declarable.h [torque] explicit exports of macros to CSA May 20, 2019
declaration-visitor.cc [torque] explicit exports of macros to CSA May 20, 2019
declaration-visitor.h [torque-ls] List macros and builtins as document symbols May 14, 2019
declarations.cc [torque] explicit exports of macros to CSA May 20, 2019
declarations.h [torque] explicit exports of macros to CSA May 20, 2019
earley-parser.cc [torque-ls] Port tests from cctest to unittest Mar 4, 2019
earley-parser.h [torque] Move Map layout definition to Torque May 16, 2019
global-context.h [torque] explicit exports of macros to CSA May 20, 2019
implementation-visitor.cc Revert "Reland "[torque] move class tests to unittests"" May 23, 2019
implementation-visitor.h [torque] Always run all ImplementationVisitor steps May 17, 2019
instructions.cc [torque] add references to HeapObject fields. Apr 11, 2019
instructions.h [torque] add references to HeapObject fields. Apr 11, 2019
parameter-difference.h [torque] Implement parameter overloading in generics Jun 6, 2018
server-data.cc [torque-ls] List macros and builtins as document symbols May 14, 2019
server-data.h [torque-ls] Support types in document-wide symbol requests May 15, 2019
source-positions.cc [torque] explicit definitions for contextual variables Jul 24, 2018
source-positions.h [torque-ls] Allow compilation of plain std::string inputs Mar 6, 2019
torque-compiler.cc [torque] More flexibel and uniform error reporting May 21, 2019
torque-compiler.h [torque] More flexibel and uniform error reporting May 21, 2019
torque-parser.cc [torque] More flexibel and uniform error reporting May 21, 2019
torque-parser.h [torque]: Class declarations Jan 10, 2019
torque.cc [torque] More flexibel and uniform error reporting May 21, 2019
type-oracle.cc [torque] Make torque declarations order independent May 7, 2019
type-oracle.h [torque] Remove LookupType(std::string&) May 14, 2019
type-visitor.cc [torque] Move Map layout definition to Torque May 16, 2019
type-visitor.h [torque] Make torque declarations order independent May 7, 2019
types.cc [torque] More flexibel and uniform error reporting May 21, 2019
types.h [torque] Move Map layout definition to Torque May 16, 2019
utils.cc [torque] More flexibel and uniform error reporting May 21, 2019
utils.h Revert "Reland "[torque] move class tests to unittests"" May 23, 2019
You can’t perform that action at this time.