Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise project branches and workflows #100

Closed
vaadin-miki opened this issue May 4, 2020 · 0 comments · Fixed by #101
Closed

Reorganise project branches and workflows #100

vaadin-miki opened this issue May 4, 2020 · 0 comments · Fixed by #101
Assignees

Comments

@vaadin-miki
Copy link
Owner

The following structure should work:

  • master should only be used for released versions, it is expected to be stable and safe to use
  • development should be main branch into which code goes, all tests pass, but the behaviour may be quirky; it has the next version + snapshot modifier in it
  • release-X.Y.Z should branch off of development, targetting master, when the release is ready; upon creating that branch all tests must be done, but before that happens a workflow should set versions of superfields and superfields-parent to whatever X.Y.Z is; once a pr is merged into master, if possible, a tag should be made automatically to it, so that a new release is done

Ticket branches should still start with a ticket number, followed by -scope of work. More than one ticket can be worked on at the same time in such branch. If it is known at the time of starting work, branch name should be A-B-scope (where A, B, are ticket numbers).

If automation is not possible to the degree described above, keep the current model.

Also, create a wiki page explaining the branches and how to contribute to this project.

@vaadin-miki vaadin-miki self-assigned this May 4, 2020
@vaadin-miki vaadin-miki added this to the Next release milestone May 4, 2020
vaadin-miki added a commit that referenced this issue May 5, 2020
sometimes I wish there was syntax checker for json files and autocomplete for github workflow files...
vaadin-miki added a commit that referenced this issue May 5, 2020
updated README.md to have {VERSION}
vaadin-miki added a commit that referenced this issue May 5, 2020
forgot quotes around export
@vaadin-miki vaadin-miki mentioned this issue May 5, 2020
vaadin-miki added a commit that referenced this issue May 6, 2020
vaadin-miki added a commit that referenced this issue May 7, 2020
vaadin-miki added a commit that referenced this issue May 7, 2020
vaadin-miki added a commit that referenced this issue May 7, 2020
turns out having a required status check that is never triggered for a branch hangs PR forever
vaadin-miki added a commit that referenced this issue May 7, 2020
there is an automated workflow that sets a version number one a branch `release-X.Y.Z` is made
vaadin-miki added a commit that referenced this issue May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant