Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to selecting the first matching path instead of the last #1

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Mar 8, 2017

Will fix vaadin/framework/issues/8734 once taken into use


This change is Reviewable

@pleku
Copy link

pleku commented Mar 9, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


modules/cpr/src/main/java/org/atmosphere/util/IOUtils.java, line 283 at r1 (raw file):

                }
                // Use the first mapping if there are multiple available
                servletPath = s.getMappings().iterator().next();

As this is still very fragile, could it be worth adding another log message stating that which servlet path was used for this ?


Comments from Reviewable

@pleku
Copy link

pleku commented Mar 9, 2017

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Artur-
Copy link
Member Author

Artur- commented Mar 9, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


modules/cpr/src/main/java/org/atmosphere/util/IOUtils.java, line 283 at r1 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

As this is still very fragile, could it be worth adding another log message stating that which servlet path was used for this ?

It's logged by the caller


Comments from Reviewable

@Artur- Artur- merged commit e5fa155 into 2.4.5 Mar 9, 2017
@Artur- Artur- deleted the servlet-mapping-order branch March 9, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants