Skip to content

Conversation

@web-padawan
Copy link
Member

  • Moved "Style variants" examples from the Button page to Styling tab
  • Updated custom CSS properties tables to mention Lumo / Aura support
  • Created a table to list variants Lumo / Aura support & Aura selectors

Copy link
Contributor

@rolfsmeds rolfsmeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably rework the variants docs at some point to be a bit more compact, but that needs a lot of thinking and can be left for later. Good enough for now, let's just change the caption of the selector column.

@web-padawan web-padawan force-pushed the refactor/move-button-styling branch from 80b4fd0 to 9d58307 Compare December 1, 2025 13:02

[cols="1,3,1"]
|===
| Variant | CSS selector | Supported by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Button this table structure makes sense, and it's mostly obvious what the individual variants do. However for other components it would be very valuable to have a description on what a variant does, especially since Aura specific theme variants don't have separate section / example.

Also the selector column makes less sense for other components, since variants there probably always use the theme attribute. Or are there other components where you use a class name?

So maybe we should rather have a description column, and then specifically for Button have some additional paragraph that Aura requires applying class names for success / warning / error instead of the theme attribute?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks. Added the "description" column with the usage recommendation (text mostly copied from below with some slight adjustments) and a "note" admonition regarding Aura CSS class names.

Comment on lines 52 to 62
|Success
|Recommended as an additional color option
|Lumo, Aura

|Error
|Recommended for dangerous or irreversible actions
|Lumo, Aura

|Warning
|Recommended for actions related to warnings
|Lumo, Aura
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could unify the order in which Aura and Lumo are listed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

AI Language Review

The updated documentation consolidates information well but has removed sections that provided a more comprehensive understanding of button styles and their usage. Below are some issues and suggestions:

  1. Removed Section on Styles:

    • The new version omits detailed sections on styles such as Danger, Warning, and Size Variants. Consider restoring these details as they help users understand when and why to use certain styles.
  2. Removed Example Tables:

    • The new documentation has removed tables that provided a quick reference for style variants and their recommendations. Consider reintroducing these tables for easy reference, maintaining usability for developers needing quick guidance.
  3. Footnotes for Special Cases:

    • The previous document mentioned that certain combinations, like "Tertiary + Contrast," should be avoided due to their similarity to non-interactive text. This information is crucial for preventing design issues and should be included.
  4. Focus on Theming:

    • The focus is heavily on textual descriptions rather than visual examples in the new version. Consider including more examples or visual aids directly related to the themes discussed, which could enhance comprehension.

By addressing these points, you can enhance the clarity and usefulness of the Button documentation for users, ensuring it provides both comprehensive information and quick, accessible insights.

@web-padawan web-padawan changed the title refactor: rewrite button syling docs to mention Aura docs: rewrite button syling docs to mention Aura Dec 1, 2025
@web-padawan web-padawan removed the request for review from vursen December 2, 2025 07:56
@web-padawan web-padawan dismissed rolfsmeds’s stale review December 2, 2025 08:02

The comment has been addressed and the variants table is updated.

@web-padawan web-padawan removed the request for review from rolfsmeds December 2, 2025 08:09
@web-padawan web-padawan merged commit 1d95430 into main Dec 2, 2025
4 checks passed
@web-padawan web-padawan deleted the refactor/move-button-styling branch December 2, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants