-
Notifications
You must be signed in to change notification settings - Fork 214
docs: move dialog no-padding variant to styling page #4861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AI Language ReviewThe only notable difference between the two versions is the added section on "Style Variants" and "Theming properties" in the For the "Dialog Styling" section starting with "== Style Variants", ensure the features match the Vaadin design system accurately, as there is an inconsistency under Title line height – repeated as Title font weight. Consider revising the section for accurate property descriptions and values. |
| :toclevels: 2 | ||
|
|
||
|
|
||
| == Style Variants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar question as in: #4859 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a table with a single no-padding variant for now.
| :toclevels: 2 | ||
|
|
||
|
|
||
| == Style Variants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are actually quite a few style properties for Dialog, though I'm not sure if that was supposed to be part of this PR.
IMO it would be easier to apply all changes for a component at once, otherwise it will be hard to track what has been done and what not (at least based on the current spreadsheet)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks. There are indeed a few base style properties, I will add those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
29295ae to
d43c5b3
Compare
Moved "no-padding" example to the Styling page.