Skip to content

Conversation

@web-padawan
Copy link
Member

Moved "no-padding" example to the Styling page.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

AI Language Review

The only notable difference between the two versions is the added section on "Style Variants" and "Theming properties" in the Dialog documentation.

For the "Dialog Styling" section starting with "== Style Variants", ensure the features match the Vaadin design system accurately, as there is an inconsistency under Title line height – repeated as Title font weight. Consider revising the section for accurate property descriptions and values.

@web-padawan web-padawan removed the request for review from sissbruecker December 1, 2025 15:10
:toclevels: 2


== Style Variants
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar question as in: #4859 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a table with a single no-padding variant for now.

:toclevels: 2


== Style Variants
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually quite a few style properties for Dialog, though I'm not sure if that was supposed to be part of this PR.

IMO it would be easier to apply all changes for a component at once, otherwise it will be hard to track what has been done and what not (at least based on the current spreadsheet)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks. There are indeed a few base style properties, I will add those.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@web-padawan web-padawan force-pushed the refactor/move-dialog-styling branch from 29295ae to d43c5b3 Compare December 1, 2025 16:09
@web-padawan web-padawan merged commit dc1b664 into main Dec 2, 2025
4 checks passed
@web-padawan web-padawan deleted the refactor/move-dialog-styling branch December 2, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants