New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use StaticFileHandler as a service #10229
Conversation
de66370
to
565cf81
Compare
|
Done (I hope). |
|
Now Lit template tests fail |
yeah, yeah, it will be a long journey. All the modules which use VaadinServlet for some reason may fail. |
| if (request instanceof HttpServletRequest && ((HttpServletRequest) request).getRequestedSessionId() == null) { | ||
| if (request instanceof HttpServletRequest | ||
| && ((HttpServletRequest) request) | ||
| .getRequestedSessionId() == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -51,7 +52,7 @@ | |||
| DeprecatedPolymerPublishedEventHandler.class, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
SonarQube analysis reported 7 issues Watch the comments in this conversation to review them. 5 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
|
Hi @denis-anisimov , this commit cannot be picked to 6.0 by this bot, can you take a look and pick it manually? |
refactor: use StaticFileHandler as a service Part of vaadin/osgi#50
* refactor: use StaticFileHandler as a service (#10229) Part of vaadin/osgi#50




Part of vaadin/osgi#50