Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compare file content from stream #10640

Merged
merged 2 commits into from Apr 16, 2021
Merged

Conversation

caalador
Copy link
Contributor

Compare jar file content and existing
target file content before writing to disk.

Compare jar file content and existing
target file content before writing to disk.
@mshabarov
Copy link
Contributor

LGTM. Not merged it yet in case someone else wants to review.

@mshabarov mshabarov merged commit dde115a into master Apr 16, 2021
3 checks passed
@mshabarov mshabarov deleted the issues/skip-temp-file-creation branch April 16, 2021 07:00
Java Framework ongoing feature work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Apr 16, 2021
vaadin-bot pushed a commit that referenced this pull request Apr 16, 2021
Compare jar file content and existing target file content before writing to disk.
vaadin-bot pushed a commit that referenced this pull request Apr 16, 2021
Compare jar file content and existing target file content before writing to disk.
vaadin-bot pushed a commit that referenced this pull request Apr 16, 2021
Compare jar file content and existing target file content before writing to disk.
vaadin-bot pushed a commit that referenced this pull request Apr 16, 2021
Compare jar file content and existing target file content before writing to disk.
vaadin-bot pushed a commit that referenced this pull request Apr 16, 2021
Compare jar file content and existing target file content before writing to disk.
vaadin-bot pushed a commit that referenced this pull request Apr 16, 2021
Compare jar file content and existing target file content before writing to disk.
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 19.0.5. For prerelease versions, it will be included in its final version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.6.0.beta2. For prerelease versions, it will be included in its final version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.5.3. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Java Framework ongoing feature work (...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants