Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set routes first into the template #11107

Merged
merged 2 commits into from Jun 1, 2021
Merged

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented May 28, 2021

fixes psi#26

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@pleku pleku requested a review from mshabarov May 31, 2021 11:15
@mshabarov
Copy link
Contributor

@fluorumlabs could you please review this PR? Merge is blocked since you requested changes. Thanks!

@mshabarov mshabarov merged commit 16a5f20 into master Jun 1, 2021
6 checks passed
@mshabarov mshabarov deleted the si-26-avoid-showing-routes branch June 1, 2021 06:40
vaadin-bot pushed a commit that referenced this pull request Jun 1, 2021
vaadin-bot pushed a commit that referenced this pull request Jun 1, 2021
vaadin-bot pushed a commit that referenced this pull request Jun 1, 2021
vaadin-bot pushed a commit that referenced this pull request Jun 1, 2021
vaadin-bot pushed a commit that referenced this pull request Jun 1, 2021
vaadin-bot added a commit that referenced this pull request Jun 1, 2021
fixes psi#26

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jun 1, 2021
fixes psi#26

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jun 1, 2021
fixes psi#26

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jun 1, 2021
fixes psi#26

Co-authored-by: Denis <denis@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 21.0.0.alpha3. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants