Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log error messages #16935

Merged
merged 2 commits into from
Jun 5, 2023
Merged

fix: log error messages #16935

merged 2 commits into from
Jun 5, 2023

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Jun 1, 2023

Log error messages and throw more
generic exceptions.

@caalador
fix: log error messages
1fa4976 
Log error messages and throw more
generic exceptions.
@github-actions
Copy link

github-actions bot commented Jun 1, 2023 •
edited
Loading

Test Results

   992 files  ±  0     992 suites  ±0   1h 29m 22s ⏱️ +39s
6 300 tests ±  0  6 259 ✔️ ±0  41 💤 ±0  0 ❌ ±0 
6 535 runs   - 11  6 489 ✔️  - 9  46 💤  - 2  0 ❌ ±0 

Results for commit e13da1c. ± Comparison against base commit 5191b6e.

♻️ This comment has been updated with latest results.

@caalador
Update messages to point to logs.
e13da1c 
Start both error and log with same string.
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@caalador caalador merged commit 43241d4 into main Jun 5, 2023
@caalador caalador deleted the update/exception-messages branch June 5, 2023 09:27
vaadin-bot pushed a commit that referenced this pull request Jun 5, 2023
@caalador @vaadin-bot
fix: log error messages (#16935)
c94a943 
Log error messages and throw more
generic exceptions.
vaadin-bot pushed a commit that referenced this pull request Jun 5, 2023
@caalador @vaadin-bot
fix: log error messages (#16935)
2e30999 
Log error messages and throw more
generic exceptions.
@vaadin-bot
Copy link
Collaborator

Hi @caalador and @caalador, when i performed cherry-pick to this commit to 2.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 43241d4
error: could not apply 43241d4... fix: log error messages (#16935)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot pushed a commit that referenced this pull request Jun 5, 2023
@caalador @vaadin-bot
fix: log error messages (#16935)
826ea4a 
Log error messages and throw more
generic exceptions.
vaadin-bot pushed a commit that referenced this pull request Jun 5, 2023
@caalador @vaadin-bot
fix: log error messages (#16935)
d44dae6 
Log error messages and throw more
generic exceptions.
vaadin-bot pushed a commit that referenced this pull request Jun 5, 2023
@caalador @vaadin-bot
fix: log error messages (#16935)
d22d308 
Log error messages and throw more
generic exceptions.
vaadin-bot added a commit that referenced this pull request Jun 5, 2023
@vaadin-bot @caalador
fix: log error messages (#16935) (#16959)
4023888 
Log error messages and throw more
generic exceptions.

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jun 5, 2023
@vaadin-bot @caalador
fix: log error messages (#16935) (#16962)
6dbb2da 
Log error messages and throw more
generic exceptions.

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
caalador added a commit that referenced this pull request Jun 5, 2023
@caalador
fix: log error messages (#16935) (CP: 2.9)
f74b8c7 
Log error messages and throw more
generic exceptions.
vaadin-bot added a commit that referenced this pull request Jun 5, 2023
@vaadin-bot @caalador
fix: log error messages (#16935) (#16960)
1717a07 
Log error messages and throw more
generic exceptions.

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jun 5, 2023
@vaadin-bot @caalador
fix: log error messages (#16935) (#16958)
4ddc1a9 
Log error messages and throw more
generic exceptions.

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jun 5, 2023
@vaadin-bot @caalador
fix: log error messages (#16935) (#16961)
2b81a15 
Log error messages and throw more
generic exceptions.

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
mshabarov pushed a commit that referenced this pull request Jun 5, 2023
@caalador
fix: log error messages (#16935) (CP: 2.9) (#16963)
1814087 
Log error messages and throw more
generic exceptions.
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Legioth Legioth Legioth left review comments

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
cherry-picked-1.0 cherry-picked-2.9 cherry-picked-9.1 cherry-picked-23.3 cherry-picked-24.0 cherry-picked-24.1 prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha1 target/1.0 target/2.9 target/9.1 target/23.3 target/24.1 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caalador @vaadin-bot @Legioth @mcollovati