Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageRenderer should support font icons #7278

Closed
vaadin-bot opened this issue Oct 28, 2015 · 5 comments
Closed

ImageRenderer should support font icons #7278

vaadin-bot opened this issue Oct 28, 2015 · 5 comments
Labels
duplicate enhancement workaround Workaround provided in ticket comments

Comments

@vaadin-bot
Copy link
Collaborator

Originally by @tmattsso


the API for ImageRenderer supports Resources, and font icons are resources. Right now this combination just fails.


Imported from https://dev.vaadin.com/ issue #19214

@vaadin-bot
Copy link
Collaborator Author

Originally by @jdahlstrom


This is a documented lacking feature; using a font icon should result in a server-side exception explaining what is going on. The lack of font icon support is caused by the fact that font icons are very different from other Resources, and supporting them without hacks is not trivial. However, I certainly agree that it is unexpected that they do not work.

@vaadin-bot
Copy link
Collaborator Author

Originally by @tmattsso


also, sampler has something called FontIconRenderer, which doesn't exist: http://demo.vaadin.com/sampler/#ui/grids-and-trees/grid/renderers

@stale
Copy link

stale bot commented Mar 19, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Mar 19, 2018
@TatuLund
Copy link
Contributor

Font icons can be rendered using HtmlRenderer easily, see below an example of rendering check mark based on boolean property "something" of the bean

grid.addColumn(bean-> (bean.isSomething() ? VaadinIcons.CHECK_CIRCLE : VaadinIcons.CIRCLE).getHtml(), new HtmlRenderer()).setCaption("Checked");

@stale stale bot removed the Stale Stale bot label label Jan 31, 2020
@TatuLund TatuLund added enhancement workaround Workaround provided in ticket comments labels Jan 31, 2020
@TatuLund
Copy link
Contributor

Closed as duplicate for more generic ticket #7019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate enhancement workaround Workaround provided in ticket comments
Projects
None yet
Development

No branches or pull requests

2 participants