Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: up arrow listener does not work #9507

Closed
SomMeri opened this issue Jun 8, 2017 · 4 comments
Closed

Grid: up arrow listener does not work #9507

SomMeri opened this issue Jun 8, 2017 · 4 comments
Labels

Comments

@SomMeri
Copy link

SomMeri commented Jun 8, 2017

Shortcut listener on grid does not work with arrows.

Example code - three listeners for A, ARROW_UP and DELETE:

    addShortcutListener(new ShortcutListener("aaa", KeyCode.A, null) {
      
      @Override
      public void handleAction(Object sender, Object target) {
        System.out.println("a");
      }
    });

    addShortcutListener(new ShortcutListener("up", KeyCode.ARROW_UP, null) {
      
      @Override
      public void handleAction(Object sender, Object target) {
        System.out.println("UP");
      }
    });

    addShortcutListener(new ShortcutListener("delete", KeyCode.DELETE, null) {
      
      @Override
      public void handleAction(Object sender, Object target) {
        System.out.println("delete");
      }
    });

Then I focused the grid and pressed each key couple of times - the arrow was ignored. A worked, delete worked, arrow up did not worked.

Vaadin version: 8.0.6

@hesara
Copy link
Contributor

hesara commented Jun 21, 2017

The client side class Grid.CellFocusHandler.handleNavigationEvent() swallows certain keypresses that it handles itself. A custom implementation of GridEventHandler on the client side might be able to override this, but currently this cannot be done directly from server side code.

@SomMeri
Copy link
Author

SomMeri commented Jul 7, 2017

@hesara Thank you.

@stale
Copy link

stale bot commented Mar 19, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@TatuLund
Copy link
Contributor

A custom implementation of GridEventHandler on the client side might be able to override this

Grid FastNavigation add-on sort of does that and gives focus tracker and event to listen if you want to follow cursor key actions.

https://vaadin.com/directory/component/gridfastnavigation-add-on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants