Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize caption used in Grid header #11644

Merged
merged 2 commits into from Jul 1, 2019
Merged

Sanitize caption used in Grid header #11644

merged 2 commits into from Jul 1, 2019

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Jul 1, 2019

Thanks for submitting a pull request!
Please confirm that your pull request follows our guidelines found in CONTRIBUTING and that you provide enough information so that we can review your pull request.

<Description of pull request, e.g. "Fix Grid Column not sortable with backend data and sort property">

Fixes #

Check when you have completed
[ ] Valid tests for the pull request
[ ] Contributing guidelines implemented


This change is Reviewable

@ZheSun88 ZheSun88 changed the title Sanitize input used in Grid header Sanitize caption used in Grid header Jul 1, 2019
Copy link
Contributor

@TatuLund TatuLund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @TatuLund)

TatuLund added a commit that referenced this pull request Jul 1, 2019
Copy link
Contributor

@TatuLund TatuLund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ZheSun88 ZheSun88 merged commit 2584e9a into master Jul 1, 2019
@ZheSun88 ZheSun88 added this to the 8.9.0 milestone Jul 1, 2019
@ZheSun88 ZheSun88 deleted the xss-grid-header branch July 1, 2019 11:58
@ZheSun88 ZheSun88 modified the milestones: 8.9.0, 8.8.5 Jul 1, 2019
ZheSun88 added a commit that referenced this pull request Jul 1, 2019
* Sanitize input used in Grid header
ZheSun88 added a commit that referenced this pull request Jul 1, 2019
* Sanitize input used in Grid header
ZheSun88 added a commit that referenced this pull request Jul 1, 2019
* Sanitize input used in Grid header
ZheSun88 pushed a commit that referenced this pull request Jul 2, 2019
glebfox pushed a commit to cuba-platform/vaadin that referenced this pull request Jul 11, 2019
* Sanitize input used in Grid header
Ansku added a commit to Ansku/framework that referenced this pull request May 20, 2020
OlliTietavainenVaadin pushed a commit that referenced this pull request May 20, 2020
* Sanitize caption used in compatibility Grid header

Cherry pick of #11644
ZheSun88 pushed a commit that referenced this pull request May 26, 2020
* Sanitize caption used in compatibility Grid header

Cherry pick of #11644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants