Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use time-constant comparison for CSRF tokens #12190

Merged
merged 4 commits into from Feb 4, 2021
Merged

fix: use time-constant comparison for CSRF tokens #12190

merged 4 commits into from Feb 4, 2021

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Jan 28, 2021

This hardens the framework against a theoretical timing attack based on
comparing how quickly a request with an invalid CSRF token is rejected.

Backporting of #12188


This change is Reviewable

This hardens the framework against a theoretical timing attack based on
comparing how quickly a request with an invalid CSRF token is rejected.
TatuLund added a commit that referenced this pull request Jan 28, 2021
This is the same as #12190, but also applied for the upload security key
and the push id since both of those are also used to protect against
cross-site attacks. In addition, documentation for the push id is
clarified to point out its role.
@TatuLund TatuLund added the v7 label Jan 28, 2021
TatuLund added a commit that referenced this pull request Jan 28, 2021
This is the same as #12190, but also applied for the upload security key
and the push id since both of those are also used to protect against
cross-site attacks. In addition, documentation for the push id is
clarified to point out its role.
Ansku pushed a commit that referenced this pull request Feb 3, 2021
This is the same as #12190, but also applied for the upload security key
and the push id since both of those are also used to protect against
cross-site attacks. In addition, documentation for the push id is
clarified to point out its role.

Backporting of #12189
Copy link
Member

@Ansku Ansku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Ansku Ansku merged commit a26eb8d into 7.7 Feb 4, 2021
3 checks passed
@Ansku Ansku deleted the csrf-fix1-2 branch February 4, 2021 12:23
@tarekoraby tarekoraby added this to the 7.7.24 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants