Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data-location attribute in CustomLayout #8866

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

hesara
Copy link
Contributor

@hesara hesara commented Mar 17, 2017

Fixes #8416


This change is Reviewable

@hesara hesara requested a review from elmot March 17, 2017 09:35
@elmot
Copy link
Contributor

elmot commented Mar 20, 2017

:lgtm:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@elmot elmot merged commit 1d127a0 into master Mar 20, 2017
@elmot elmot deleted the 8416_customlayout_data_location branch March 20, 2017 15:10
@pleku pleku added this to the 8.0.4 milestone Mar 22, 2017
pleku pushed a commit that referenced this pull request Mar 22, 2017
hesara added a commit that referenced this pull request Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants