Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exact route matching in Vaadin.Resolver by default #64

Closed
vlukashov opened this issue May 2, 2018 · 0 comments
Closed

Use exact route matching in Vaadin.Resolver by default #64

vlukashov opened this issue May 2, 2018 · 0 comments
Milestone
M1

Comments

@vlukashov
Copy link
Contributor

As a developer I want exact route matching to be the default so that the routing config is more intuitive and wrong URLs are easier to detect.

DoD:

  • Vaadin.Resolver is updated so that if a route does not have an exact property it matches a route only if the given pathname exactly matches the route path (trailing slashes are optional).
  • the specs for resolveRoute and Vaadin.Resolver are updated
@vlukashov vlukashov added this to the M1 milestone May 2, 2018
@vlukashov vlukashov mentioned this issue May 3, 2018
Merged
vlukashov pushed a commit that referenced this issue May 3, 2018
- update the matchRoute() spec to exact matching by default
bed12fd 
 - re-arrange the test cases in the matchRoute() spec to clarify "" and "/" routes matching and the role of the trailing and leading "/" in the route paths
 - update the matchRoute() implementation to match the updated spec
 - remove the `exact` property from the Vaadin.Router JSDocs and specs

Fixes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M1
Development

No branches or pull requests
1 participant
@vlukashov